On 09/18/2011 08:32 PM, Sébastien Bourdeauducq wrote:
Hi,

merged and corrected: * skip as well on patch switch (not only *
missing close() in check_input_require() (function renamed to
check_input_video) * avoidable modification of a global variable in
check_input_require() * style

Hi Sebastien

thanks, always needs improve my C skill. :)


Checking DMX status is not possible with the current Verilog code.
MIDI and OSC do not send any signal when no transmission of a message
is taking place, so there is no way of telling if they are
connected.

We can simply skip "advanced" DMX, MIDI and OSC patches - people
using those certainly do not want the simple performance mode.


sound good.
when I try OSC I will not use the 'Simple' mode :)


one little thing , the performance.c line 529, will affect the
'Configured' mode. if the first patch is about Video_in, and there is
no camera connected right now, it will skip the first patch.
(people may connect the camera later when you saw there is no video_in in 
'Configured' mode)

if you agree I will push the commit, like:

~~~~
diff --git a/src/performance.c b/src/performance.c
index 5deea4c..e48c22a 100644
--- a/src/performance.c
+++ b/src/performance.c
@@ -523,16 +523,17 @@ void start_performance(int simple, int dt, int as)
        if(started) return;
        started = 1;
+ input_video = 1;
        simple_mode = simple;
        dt_mode = dt;
        as_mode = as;
-       input_video = check_input_video();
        open_performance_window();
/* build patch list */
        npatches = 0;
        current_patch = 0;
        if(simple) {
+               input_video = check_input_video();
                add_simple_patches();
                if(npatches < 1) {
                        messagebox("Error", "No patches found!");

_______________________________________________
http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org
IRC: #milkymist@Freenode

Reply via email to