Xiangfu Liu wrote:
> Subject: [PATCH v2 3/3] use Makefile manage the build progress cleanup
>  the gcc output, make V=1 will output all detail message

Looks great ! Two details:

- some lines are longer than 80 characters

- I wouldn't hide .PHONY amidst the rules. Make doesn't care there
  it is, but a human reader might.

Thanks,
- Werner
_______________________________________________
http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org
IRC: #milkymist@Freenode

Reply via email to