Hello,
may I take the liberty to remind you to commit this outstanding fix.
Than you.
Bert Wesarg
Brian Barrett wrote:
> Very true, thanks. I'll fix this evening.
>
> Brian
>
> On Feb 25, 2007, at 4:51 AM, Bert Wesarg wrote:
>
>> Hallo,
>>
>> ok the sed should be even more portable. but the problem with a CC
>> like
>> "gcc -m32" isn't solved, so you should add this line and use the
>> $tmpCC
>> in the sed expression, to get "gcc -m32" removed:
>>
>> tmpCC=`echo $CC`
>>
>> Bert
>>
>> Brian W. Barrett wrote:
>>> Thanks for the bug report and the patch. Unfortunately, the remove
>>> smallest prefix pattern syntax doesn't work with Solaris /bin/sh
>>> (standards would be better if everyone followed them...), but I
>>> committed something to our development trunk that handles the issue.
>>> It should be releases as part of v1.2.1 (we're too far in testing to
>>> make it part of v1.2).
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>>
>>> On Feb 15, 2007, at 9:12 AM, Bert Wesarg wrote:
>>>
>>>> Hello,
>>>>
>>>> when using a multi token CC variable (like "gcc -m32"), the logic to
>>>> extract $extra_ldflags from libtool don't work. So here is a little
>>>> hack
>>>> to remove the $CC prefix from the libtool-link cmd.
>>>>
>>>> Bert Wesarg
>>>> diff -ur openmpi-1.1.4/config/ompi_get_libtool_linker_flags.m4
>>>> openmpi-1.1.4-extra_ldflags-fix/config/
>>>> ompi_get_libtool_linker_flags.m4
>>>> --- openmpi-1.1.4/config/ompi_get_libtool_linker_flags.m4
>>>> 2006-04-12 18:12:28.000000000 +0200
>>>> +++ openmpi-1.1.4-extra_ldflags-fix/config/
>>>> ompi_get_libtool_linker_flags.m4 2007-02-15 15:11:28.285844893 +0100
>>>> @@ -76,11 +76,15 @@
>>>> cmd="$libtool --dry-run --mode=link --tag=CC $CC bar.lo libfoo.la -
>>>> o bar $extra_flags"
>>>> ompi_check_linker_flags_work yes
>>>>
>>>> +# use array initializer to remove multiple spaces in $CC
>>>> +tempCC=($CC)
>>>> +tempCC="${tempCC[@]}"
>>>> +output="${output#$tempCC}"
>>>> +unset tempCC
>>>> eval "set $output"
>>>> extra_ldflags=
>>>> while test -n "[$]1"; do
>>>> case "[$]1" in
>>>> - $CC) ;;
>>>> *.libs/bar*) ;;
>>>> bar*) ;;
>>>> -I*) ;;
>>>> _______________________________________________
>>>> devel mailing list
>>>> de...@open-mpi.org
>>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> _______________________________________________
>>> devel mailing list
>>> de...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> _______________________________________________
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
