On Apr 18, 2007, at 7:55 AM, Sharon Melamed wrote:
I want to add a patch to opal mca.
This patch replaces an ‘atoi’ call with a ‘strtol’ call.
If it’s O.K with everyone I’ll submit this patch by the end of the
week.
With the (int) cast, I'm ok with it now. :-)
The man pages on Linux, OSX, and Solaris all describe similar
functionality, so I think you should be ok.
Index: opal/mca/base/mca_base_param.c
===================================================================
--- opal/mca/base/mca_base_param.c (revision 14391)
+++ opal/mca/base/mca_base_param.c (working copy)
@@ -1673,7 +1673,7 @@
if (NULL != param->mbp_env_var_name &&
NULL != (env = getenv(param->mbp_env_var_name))) {
if (MCA_BASE_PARAM_TYPE_INT == param->mbp_type) {
- storage->intval = atoi(env);
+ storage->intval = (int)strtol(env,(char**)NULL,0);
} else if (MCA_BASE_PARAM_TYPE_STRING == param->mbp_type) {
storage->stringval = strdup(env);
}
@@ -1714,7 +1714,7 @@
if (0 == strcmp(fv->mbpfv_param, param->mbp_full_name)) {
if (MCA_BASE_PARAM_TYPE_INT == param->mbp_type) {
if (NULL != fv->mbpfv_value) {
- param->mbp_file_value.intval = atoi(fv-
>mbpfv_value);
+ param->mbp_file_value.intval = (int)strtol(fv-
>mbpfv_value,(char**)NULL,0);
} else {
param->mbp_file_value.intval = 0;
}
Thanks.
Sharon.
_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
--
Jeff Squyres
Cisco Systems
