I think this fits into the same category of objections as to the other
RFC - it should be done in the tmp branch and held there until the
entire concept is validated.
In this case, my concern would focus solely on the question of
conversion time. Somewhere up the chain, somebody is passing an
ompi_info_t that eventually hits this level. At what level would we
have to convert that to an opal_list_t, and what timing would be
impacted by that conversion?
Minus that understanding, there really is no way to judge the
potential impact of this proposed change.
Ralph
On Jan 30, 2009, at 12:29 PM, Rainer Keller wrote:
Send yet again...
RFC: Change of API in mpool
WHAT: Remove dependency on ompi_info_t in mca_mpool_base_alloc
WHY: To be able to move mpool out of the ompi-layer.
WHERE: Changes just in the mpool and in ompi/mpi/c/alloc_mem.c
WHEN: Open MPI-1.4
TIMEOUT: February 3, 2009.
-------------------------------------
Details:
WHY:
With the proposed move of the BTL framework out of the ompi-layer, we
need to move/copy a few dependant class- and other functionality
with it
(omp_free_list, ompi_bitmap, ompi_rb_tree, common, mpool, allocator,
rcache).
The only real dependency problem, visible right now, that requires a
change is the function mca_mpool_base_alloc, which requires
ompi_info_t.
WHAT:
In order to make mca_mpool_base_alloc oblivious of MPI, we'd propose
passing all relevant info as opal_list_t -- and prepare this by the
only
caller ompi/mpi/c/alloc_mem.c, which only copies ("mpool",value)-pairs
into a list (if there are any).
The patchlet can be applied to trunk / or the branch koenig-btl,
however,
I left out the required (but boring) svn mv and rename of ompi->onet.
Has been tested with the supplied test-program, produces the expected
results.
Any comments are welcome.
CU,
Rainer
--
------------------------------------------------------------------------
Rainer Keller, PhD Tel: (865) 241-6293
Oak Ridge National Lab Fax: (865) 241-4811
PO Box 2008 MS 6164 Email: kel...@ornl.gov
Oak Ridge, TN 37831-2008 AIM/Skype: rusraink
<
mpool_patchlet
-2009.01.29
.diff><mpi_info_test.c>_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
