Could we hold off on this until after 1.3.2 is out the door and has a
couple of days to stabilize? All these header file changes are making
it more difficult to cleanly apply patches to the 1.3 branch.
When we get past the next couple of weeks, the 1.3 branch should clear
out the backlog of CMRs, and we should have the usual immediate "oops"
fixes in to 1.3.2. Then this won't be such a problem.
Thanks
Ralph
On Mar 17, 2009, at 4:41 PM, Rainer Keller wrote:
What: Delete unused headers (intrusive)
Why: Get rid of needlessly included headers
Where: On trunk -- but I am playing safe -- hence this RFC
When: Apply on trunk on 20.3. (in the evening before MTT tar
ball, but
not to disturb other people's work)
Timeout: Afternoon of 20.03.2009 (for comments or hold-off notice)
------------------------------------------------------------------------
In the frame of the BTL-move work a libopen-net library is created,
several
dependencies have been resolved.
Some still remain: we include headers all over the place, which is
technically
not an error. However, it's not nice in order to resolve some
problems and not
the Right Thing(tm).
We'd propose to apply the following script (with the diff file
showing a
preliminary example of what's submitted modulo the stuff in ompi/mpi/
c/*),
which then would only remove headers, which are _not_ needed (as
figured by
below script), as said in today's telcon.
Todays patches at first _add_ some of the required headers, which
later are
needed anyway (iff the deletion of headers in included-files is done).
As this deletion is _intrusive_ (touching ~800 files, mostly just
single-
liners), I would like to get feedback and comments, whether it
breaks anything
in any branches or has other negative effects in any branches of
partners or
is considered to be overly intrusive / should be split...
With best regards,
Rainer
--
------------------------------------------------------------------------
Rainer Keller, PhD Tel: +1 (865) 241-6293
Oak Ridge National Lab Fax: +1 (865) 241-4811
PO Box 2008 MS 6164 Email: kel...@ornl.gov
Oak Ridge, TN 37831-2008 AIM/Skype: rusraink
<
check_unnecessary_headers
.sh
.bz2
>
<
ompi_cleanup_header
-2009.03.17.diff.bz2>_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
