I wonder why the mpool is so special that it doesn't inherit the logic from the MCA base with regard to opening only the components that match the user input?

  george.

On Apr 21, 2009, at 08:43 , Jeff Squyres wrote:

Thanks!  I've committed a slightly different fix here:

   https://svn.open-mpi.org/trac/ompi/changeset/21044


On Apr 20, 2009, at 10:39 AM, Roberto Ammendola wrote:


I found a small bug in function mca_mpool_base_module_create() where if a
bad name is provided for mpool component, last iterated component is
returned, instead of NULL. I suggest a solution:

===================================================================
--- ompi/mca/mpool/base/mpool_base_lookup.c     (revision 21042)
+++ ompi/mca/mpool/base/mpool_base_lookup.c     (working copy)
@@ -75,11 +75,14 @@
    for (item = opal_list_get_first(&mca_mpool_base_components);
         item != opal_list_get_end(&mca_mpool_base_components);
         item = opal_list_get_next(item)) {
+         mca_mpool_base_component_t* c;
+
         mca_base_component_list_item_t *cli =
           (mca_base_component_list_item_t *) item;
-         component =
+         c =
           (mca_mpool_base_component_t *) cli->cli_component;
-         if(0 == strcmp(component->mpool_version.mca_component_name,
name)) {
+ if(0 == strcmp(c->mpool_version.mca_component_name, name)) {
+             component = c;
             break;
         }
    }


_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


--
Jeff Squyres
Cisco Systems

_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

Reply via email to