Hi Jeff,
Thanks for reviewing my changes !
On Thu, 6 Aug 2009, Jeff Squyres wrote:
-Source: openmpi-%{version}.tar.$EXTENSION
+Source: %{name}-%{version}.tar.$EXTENSION
Does this mean that you're looking for a different tarball name? I'm not
sure that's good; the tarball should be an openmpi tarball, regardless of
what name it gets installed under (e.g., OFED builds an OMPI tarball 3-4
different ways [one for each compiler] and changes %name, but uses the same
tarball. How about another param (hey, we've got something like 100, so
what's 101? ;-) ) for the tarball that defaults to "openmpi"? They if you
want to have a differently-named tarball, you can.
Well, maybe we could live with an openmpi tarball ... it was just to be
consistent. When I build bullmpi-a.b.c.src.rpm, I somehow expect the tar
file to be bullmpi-a.b.c.tar.gz.
-%setup -q -n openmpi-%{version}
+%setup -q -n %{name}-%{version}
Ditto for this.
-%dir %{_libdir}/openmpi
+%dir %{_libdir}/%{name}
Hmm -- is this right? I thought that the name "openmpi" in this directory
path came from OMPI's configure script, not from the RPM spec...? Or is the
RPM build command passing --pkgname or somesuch to OMPI's configure to
override the built-in name?
Hum, I guess you're right, this is indeed not something to change. Sorry
about that.
Sylvain
On Jul 31, 2009, at 11:51 AM, Sylvain Jeaugey wrote:
Hi all,
We had to apply a little set of modifications to the openmpi.spec file to
help us integrate openmpi in our cluster distribution.
So here is a patch which, as the changelog suggests, does a couple of
"improvements" :
- Fix a typo in Summary
- Replace openmpi by %{name} in a couple of places
- Add an %{opt_prefix} option to be able to install in a specific path
(e.g. in /opt/<vendor>/mpi/<mpilib>-<version>/ instead of
/opt/<mpilib>-<version>)
The patch is done with "hg extract" but should apply on the SVN trunk.
Sylvain<openmpi.spec.patch>_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
--
Jeff Squyres
jsquy...@cisco.com
_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
