Being user friendly is good, being way too user friendly is less (but I guess this is the price we have to pay for a production-quality code isn't it).
I have few comments: - In several places you replaced the BTL_ERROR (which was the way BTLs are supposed to complaints) by a call directly to orte_show_help. This presents several inconveniences: drifting away from something more or less consistent across all BTLs, adding more dependencies between the BTLs and ORTE. - There are a lot of places where you just indented the code or split a medium-sized line into several lines. I find the code more difficult to read. Thanks, george. On Mar 5, 2010, at 14:16 , Jeff Squyres wrote: >> From https://svn.open-mpi.org/trac/ompi/ticket/2045, I have added a lot more >> diagnostic error and verbose messages to the TCP BTL that detail what >> endpoints it creates, what IP addresses and ports its trying to connect to, >> etc. As part of this, I also added a magic ID string into the TCP BTL >> socket handshake so that processes can identify if the socket peer is an >> OMPI process. > > http://bitbucket.org/jsquyres/tcp-debug-printf/ > > The initial commit with all the new messages and whatnot is here: > > http://bitbucket.org/jsquyres/tcp-debug-printf/changeset/9efe756cda30/ > > There are now multiple levels of TCP BTL verbosity: 10, 20, and 30. Each > level gives successively more information. > > This ended up in a lot more code addition than I thought it would, so I'm a > little uncomfortable just committing it to the trunk. Can anyone who cares > have a look at this before I commit? If possible, it would be good to get > some testing on Solaris and Windows at a minimum before I commit, too -- just > to minimize the chance of trunk breakage. > > If I hear nothing back by next Friday (12 March 2010), I'll commit. > > Thanks! > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
