The comment doesn't match the commit itself. george.
On Apr 20, 2010, at 20:00 , cy...@osl.iu.edu wrote: > Author: cyeoh > Date: 2010-04-20 20:00:14 EDT (Tue, 20 Apr 2010) > New Revision: 23014 > URL: https://svn.open-mpi.org/trac/ompi/changeset/23014 > > Log: > fixes #2355 - race in interaction between opal_atomic_lifo_push > and opal_atomic_lifo_pop. Adds memory barriers to remove the race > condition > > > Text files modified: > trunk/opal/include/opal/sys/powerpc/atomic.h | 3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > Modified: trunk/opal/include/opal/sys/powerpc/atomic.h > ============================================================================== > --- trunk/opal/include/opal/sys/powerpc/atomic.h (original) > +++ trunk/opal/include/opal/sys/powerpc/atomic.h 2010-04-20 20:00:14 EDT > (Tue, 20 Apr 2010) > @@ -9,6 +9,7 @@ > * University of Stuttgart. All rights reserved. > * Copyright (c) 2004-2005 The Regents of the University of California. > * All rights reserved. > + * Copyright (c) 2010 IBM Corporation. All rights reserved. > * $COPYRIGHT$ > * > * Additional copyrights may follow > @@ -296,7 +297,6 @@ > " add %0, %2, %0 \n\t" > " stwcx. %0, 0, %3 \n\t" > " bne- 1b \n\t" > - " mr %3, %0 \n\t" > : "=&r" (t), "=m" (*v) > : "r" (inc), "r" (v), "m" (*v) > : "cc"); > @@ -314,7 +314,6 @@ > " subf %0,%2,%0 \n\t" > " stwcx. %0,0,%3 \n\t" > " bne- 1b \n\t" > - " mr %3, %0 \n\t" > : "=&r" (t), "=m" (*v) > : "r" (dec), "r" (v), "m" (*v) > : "cc"); > _______________________________________________ > svn-full mailing list > svn-f...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
