Some questions about the patch:
configure.in:
@@ -2002,9 +1987,8 @@
# Turn off the building of the Fortran interface and the Info routines
EXTRA_DIRS=""
AC_DEFINE(HAVE_STATUS_SET_BYTES,1,[Define if status_set_bytes available])
- DEFINE_HAVE_MPI_GREQUEST="#define HAVE_MPI_GREQUEST"
- # Add the MPICH2_INCLUDE_FLAGS to CPPFLAGS
- CPPFLAGS="$CPPFLAGS $MPICH2_INCLUDE_FLAGS"
+ DEFINE_HAVE_MPI_GREQUEST="#define HAVE_MPI_GREQUEST 1"
+ AC_DEFINE(HAVE_MPIU_FUNCS,1,[Define if MPICH2 memory tracing macros
defined])
fi
#
#
Do we have the MPIU functions? Or is that an MPICH2-specific thing?
I see that you moved confdb/aclocal_cc.m4 to acinclude.m4. Shoudn't we just -I
confdb instead to get all of their .m4 files?
In mpipr.h, why remove the #if 0?
-/* Open MPI: these functions are not supposed to be profiled */
-#if 0
#undef MPI_Wtick
#define MPI_Wtick PMPI_Wtick
#undef MPI_Wtime
#define MPI_Wtime PMPI_Wtime
-#endif
In configure.in, please update the version number in AM_INIT_AUTOMAKE.
I thought there was one other thing that I saw, but I can't recall it right
now...
This is just from looking at your diff; I didn't try to run it yet because you
said there were some things that weren't pushed back up to bitbucket yet.
On Nov 24, 2010, at 10:48 AM, Pascal Deveze wrote:
> Hi Jeff,
>
> Here is the unified diff.
> As only the romio subtree is modified, I made the following command:
> diff -u -r -x .svn ompi-trunk/ompi/mca/io/romio/romio/
> NEW-ROMIO-FOR-OPENMPI/ompi/mca/io/romio/romio/ > DIFF_UPDATE
> tar cvzf DIFF_UPDATE.TGZ DIFF_UPDATE
>
> Compilation is OK. I run the ROMIO tests.
>
> There are a few new modifications that are not in bitbucket. I think it is
> not necessary to update bitbucket
> (http://bitbucket.org/devezep/new-romio-for-openmpi/ ).
>
> Pascal
>
> Jeff Squyres a écrit :
>> Thanks Pascal!
>>
>> Is there any change you could send a unified diff of the tip of your hg vs.
>> the SVN trunk HEAD?
>>
>> E.g., if you have an hg+ssh combo tree, could you "hg up" in there to get
>> all your work, and then "svn diff > diff.out" and then compress and send the
>> diff.out?
>>
>> Thanks!
>>
>>
>>
>> On Nov 10, 2010, at 8:43 AM, Pascal Deveze wrote:
>>
>>
>>
>>> WHAT: Port the lastest ROMIO version from MPICH2-1.3 into the trunk.
>>>
>>> WHY: There is a considerable interest in updating the ROMIO branch that was
>>> ported from mpich2-1.0.7
>>>
>>> WHERE: ompi/mca/io/romio/
>>>
>>> WHEN: Before 1.5.2, so asap
>>>
>>> TIMEOUT: Next Tuesday teleconf, 23 Nov 2010
>>>
>>> -----
>>>
>>> I am in charge of ticket 1888 (see at
>>> https://svn.open-mpi.org/trac/ompi/ticket/1888
>>> ).
>>> I have made the porting of ROMIO available in bitbucket since September
>>> 17th 2010. (
>>> http://bitbucket.org/devezep/new-romio-for-openmpi/
>>> )
>>> Until now, I do not have any report on this porting and it's now time to
>>> bring it into the trunk.
>>> All modified files are located under the romio subtree.
>>>
>>> Pascal Devèze
>>>
>>> _______________________________________________
>>> devel mailing list
>>>
>>> [email protected]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>>
>>>
>>>
>>
>>
>>
>>
>
> <DIFF_UPDATE.TGZ>_______________________________________________
> devel mailing list
> [email protected]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
--
Jeff Squyres
[email protected]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/
