Good point (I did not even look at ompi_comm_compare, I was using this for something else). I'll take a pass at converting the ompi_comm_compare to use the ompi_group_compare functionality - it is good code reuse.
Thanks, Josh On Thu, Mar 8, 2012 at 4:08 PM, George Bosilca <bosi...@eecs.utk.edu> wrote: > Josh, > > Open MPI already have a similar function in the communicator part, > function that is not exposed to the upper layer. I think that using the > code in ompi_comm_compare (the second part that compare groups) is sound > proof. Moreover, if now we have an ompi_group_compare function you should > use it in the ompi_comm_compare to ease the readability of the code. > > Regards, > george. > > > > On Mar 8, 2012, at 16:57 , jjhur...@osl.iu.edu wrote: > > > Author: jjhursey > > Date: 2012-03-08 16:57:45 EST (Thu, 08 Mar 2012) > > New Revision: 26118 > > URL: https://svn.open-mpi.org/trac/ompi/changeset/26118 > > > > Log: > > Abstract MPI_Group_compare to an OMPI function for internal use (point > the MPI interface to the internal function). > > > -- Joshua Hursey Postdoctoral Research Associate Oak Ridge National Laboratory http://users.nccs.gov/~jjhursey
