It is a good idea to unify the OFED configure scripts. BUT, I would prefer to do this rework after merge with the new collectives component, since we are going to bring totally new IB components based on extended verbs interface and it obviously adds new configure logic.
Pavel (Pasha) Shamis --- Application Performance Tools Group Computer Science and Math Division Oak Ridge National Laboratory On Apr 27, 2012, at 7:48 AM, Jeff Squyres wrote: > OpenFabrics vendors -- > > Now that there's a verbs-based component in orte, it really suggests that we > should update / reform the configure options and behavior w.r.t. > OpenFabrics-based components. > > For example: > > - is it finally time to rename --with-openib to --with-ofa? > > - should we also allow --with-openib as a deprecated synonym for the 1.7/1.8 > series, and then kill it in 1.9? > > - should we hack up ompi/config/ompi_check_openib.m4: > > 1. split it up to check for smaller things (e.g., one macro to check for > basic OpenFabrics, another to check for the RDMACM, another to check for XRC, > ...etc.). The rationale here is that oob/ud requires very little from OFA -- > it does not need RDMACM, XRC, ...etc. > > 2. move the resulting OFA-based .m4 out to the top-level config/ directory > (vs. ompi/config)? > > ==> Jeff's $0.02 on all of this is "yes". :-) > > > > Begin forwarded message: > >> From: jsquy...@osl.iu.edu >> Subject: [OMPI svn-full] svn:open-mpi r26350 >> Date: April 27, 2012 7:32:56 AM EDT >> To: svn-f...@open-mpi.org >> Reply-To: de...@open-mpi.org >> >> Author: jsquyres >> Date: 2012-04-27 07:32:56 EDT (Fri, 27 Apr 2012) >> New Revision: 26350 >> URL: https://svn.open-mpi.org/trac/ompi/changeset/26350 >> >> Log: >> Update configury in the new oob ud component: actually check to see if >> it succeeds and run $1 or $2, accordingly. This allows "make dist" to >> run properly on machines that do not have OpenFabrics stuff installed >> (e.g., the nightly tarball build machine). >> >> There's still more to be done here -- it doesn't check for non-uniform >> directories where the OpenFabrics headers/libraries might be >> installed. We might need to re-tool/combine >> ompi/config/ompi_check_openib.m4 (which checks for way more than >> oob/ud needs) and move it up to config/ompi_check_ofa.m4, or >> something...? >> >> Properties modified: >> trunk/orte/mca/oob/ud/ (props changed) >> Text files modified: >> trunk/orte/mca/oob/ud/Makefile.am | 8 ++++++-- >> >> trunk/orte/mca/oob/ud/configure.m4 | 32 ++++++++++++++++++++++++++++++-- >> >> 2 files changed, 36 insertions(+), 4 deletions(-) >> >> Modified: trunk/orte/mca/oob/ud/Makefile.am >> ============================================================================== >> --- trunk/orte/mca/oob/ud/Makefile.am (original) >> +++ trunk/orte/mca/oob/ud/Makefile.am 2012-04-27 07:32:56 EDT (Fri, >> 27 Apr 2012) >> @@ -17,6 +17,8 @@ >> # $HEADER$ >> # >> >> +AM_CPPFLAGS = $(orte_oob_ud_CPPFLAGS) >> + >> dist_pkgdata_DATA = help-oob-ud.txt >> >> sources = \ >> @@ -49,9 +51,11 @@ >> mcacomponentdir = $(pkglibdir) >> mcacomponent_LTLIBRARIES = $(component_install) >> mca_oob_ud_la_SOURCES = $(sources) >> -mca_oob_ud_la_LDFLAGS = -module -avoid-version -libverbs >> +mca_oob_ud_la_LDFLAGS = -module -avoid-version $(orte_oob_ud_LDFLAGS) >> +mca_oob_ud_la_LIBADD = $(orte_oob_ud_LIBS) >> >> noinst_LTLIBRARIES = $(component_noinst) >> libmca_oob_ud_la_SOURCES = $(sources) >> -libmca_oob_ud_la_LDFLAGS = -module -avoid-version >> +libmca_oob_ud_la_LDFLAGS = -module -avoid-version $(orte_oob_ud_LDFLAGS) >> +libmca_oob_ud_la_LIBADD = $(orte_oob_ud_LIBS) >> >> >> Modified: trunk/orte/mca/oob/ud/configure.m4 >> ============================================================================== >> --- trunk/orte/mca/oob/ud/configure.m4 (original) >> +++ trunk/orte/mca/oob/ud/configure.m4 2012-04-27 07:32:56 EDT (Fri, >> 27 Apr 2012) >> @@ -22,6 +22,34 @@ >> AC_DEFUN([MCA_orte_oob_ud_CONFIG],[ >> AC_CONFIG_FILES([orte/mca/oob/ud/Makefile]) >> >> - AC_CHECK_HEADER([infiniband/verbs.h]) >> - AC_CHECK_LIB([ibverbs], [ibv_create_qp]) >> + # JMS Still have problems with AC_ARG ENABLE not yet having been >> + # called or CHECK_WITHDIR'ed. >> + >> + orte_oob_ud_check_save_CPPFLAGS=$CPPFLAGS >> + orte_oob_ud_check_save_LDFLAGS=$LDFLAGS >> + orte_oob_ud_check_save_LIBS=$LIBS >> + >> + OMPI_CHECK_PACKAGE([orte_oob_ud], >> + [infiniband/verbs.h], >> + [ibverbs], >> + [ibv_open_device], >> + [], >> + [$ompi_check_openib_dir], >> + [$ompi_check_openib_libdir], >> + [orte_oob_ud_check_happy=yes], >> + [orte_oob_ud_check_happy=no])]) >> + >> + CPPFLAGS=$orte_oob_ud_check_save_CPPFLAGS >> + LDFLAGS=$orte_oob_ud_check_save_LDFLAGS >> + LIBS=$orte_oob_ud_check_save_LIBS >> + >> + AS_IF([test "$orte_oob_ud_check_happy" = "yes"], >> + [$1], >> + [$2]) >> + >> + # substitute in the things needed to build this component >> + AC_SUBST([orte_oob_ud_CFLAGS]) >> + AC_SUBST([orte_oob_ud_CPPFLAGS]) >> + AC_SUBST([orte_oob_ud_LDFLAGS]) >> + AC_SUBST([orte_oob_ud_LIBS]) >> ])dnl >> _______________________________________________ >> svn-full mailing list >> svn-f...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full > > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
