So if I understand this right, you would have multiple platform files, each "sourcing" a common one that contains the base directives? It sounds to me like you need more than the change below to make that work - you would need to interpret the platform file itself to read and execute a "source" directive inside it, wouldn't you?
It would really help if your change (either comments or the RFC) actually explained what the heck you are doing so I wouldn't have to waste hours trying to figure out the impact of this patch :-/ On Jul 9, 2012, at 2:25 PM, Nathan Hjelm wrote: > LANL's platform file's (for a particular platform) are 90% the same. By > allowing a source directive those settings can be kept in a common file then > sourced by the platform file. When something changes I wouldn't have to > change a dozen files only a couple. > > -Nathan > > On Mon, Jul 09, 2012 at 02:21:28PM -0700, Ralph Castain wrote: >> I'm confused - how does this help maintain a platform file??? >> >> >> On Jul 9, 2012, at 2:09 PM, Nathan Hjelm wrote: >> >>> When: Thurs, Jul 12, 5 PM MDT >>> >>> Why: Useful feature. Enabling source may cut down on the maintenance >>> required to keep platform files up to date. >>> >>> How: Change directories to the platform file's directory before sourcing it >>> (not after). >>> >>> diff --git a/config/ompi_load_platform.m4 b/config/ompi_load_platform.m4 >>> index 7231f83..250e7d8 100644 >>> --- a/config/ompi_load_platform.m4 >>> +++ b/config/ompi_load_platform.m4 >>> @@ -50,7 +50,18 @@ AC_DEFUN([OMPI_LOAD_PLATFORM], [ >>> # eval into environment >>> OPAL_LOG_MSG([Loading environment file $with_platform, with contents >>> below]) >>> OPAL_LOG_FILE([$with_platform]) >>> - . "$with_platform" >>> + >>> + # setup by getting full pathname for the platform directories >>> + platform_base="`dirname $with_platform`" >>> + platform_file="`basename $with_platform`" >>> + # get full pathname of where we are so we can return >>> + platform_savedir="`pwd`" >>> + # go to where the platform file is located >>> + cd "$platform_base" >>> + # get the full path to this location >>> + platform_file_dir=`pwd` >>> + >>> + . "$platform_file" >>> >>> # see if they left us a name >>> if test "$OMPI_PLATFORM_LOADED" != "" ; then >>> @@ -63,14 +74,6 @@ AC_DEFUN([OMPI_LOAD_PLATFORM], [ >>> >>> # look for default mca param file >>> >>> - # setup by getting full pathname for the platform directories >>> - platform_base="`dirname $with_platform`" >>> - # get full pathname of where we are so we can return >>> - platform_savedir="`pwd`" >>> - # go to where the platform file is located >>> - cd "$platform_base" >>> - # get the full path to this location >>> - platform_file_dir=`pwd` >>> # return to where we started >>> cd "$platform_savedir" >>> >>> >>> -Nathan >>> _______________________________________________ >>> devel mailing list >>> de...@open-mpi.org >>> http://www.open-mpi.org/mailman/listinfo.cgi/devel >> >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/devel > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
