On Tue, Oct 30, 2012 at 01:16:17PM -0700, Ralph Castain wrote: > Actually, now that I look at it, I'm not sure what Jeff is talking about here > is correct. I think Nathan's patch is in fact right. > > Nathan's change doesn't in any way impact what gets passed to remote procs. > All it does is modify what gets passed on the *orted's* command line. The > orted has no idea what OMPI_foo means as an argument on its command line, and > I don't think we want to change it.
Exactly! The loop is meant to add mca options the user has set via env vars that are not already on the command line. Some examples with the wrong conditional (env var -> orted option): OMPI_COMMAND=foo ---> -mca AND foo OMPI_PATH=foo ---> -mca foo OMPI_MCA_bar=foo ---> -mca bar foo OMPI_=f ---> SEGV (possibly) -- shorter than 9 characters long -Nathan
