Problem is that the orte function no longer seems to exist, so build fails

Sent from my iPhone

On Nov 7, 2012, at 7:55 AM, Nathan Hjelm <hje...@lanl.gov> wrote:

> Ok, looks like the default yyterminate does not clean up the lex state. The 
> definition in rmaps/rankfile/rmaps_rank_file_lex.l should be
> 
> #define yyterminate() return orte_rmaps_rank_file_lex_destroy()
> 
> I can fix it if you want.
> 
> -Nathan
> 
> On Wed, Nov 07, 2012 at 08:34:59AM -0700, Nathan Hjelm wrote:
>> Hmm, not sure why I didn't see an error when I tested the change. It looks 
>> like in this case yyterminate should have been defined as 
>> orte_rmaps_rank_file_lex_destroy(). Looked a little deeper and it looks like 
>> the default action for yyterminate is to call the *lex_destroy function so 
>> we don't need to define it anywhere. Let me see if deleting yyterminate 
>> introduces any leaks.
>> 
>> -Nathan
>> 
>> On Wed, Nov 07, 2012 at 06:11:06AM -0500, svn-commit-mai...@open-mpi.org 
>> wrote:
>>> Author: rhc (Ralph Castain)
>>> Date: 2012-11-07 06:11:05 EST (Wed, 07 Nov 2012)
>>> New Revision: 27574
>>> URL: https://svn.open-mpi.org/trac/ompi/changeset/27574
>>> 
>>> Log:
>>> A prior commit apparently broke the trunk when something was inadvertently 
>>> left behind - so remove a reference to a no-longer-existing function
>>> 
>>> Text files modified: 
>>>   trunk/orte/mca/rmaps/rank_file/rmaps_rank_file_lex.l |     3 ---          
>>>                            
>>>   1 files changed, 0 insertions(+), 3 deletions(-)
>>> 
>>> Modified: trunk/orte/mca/rmaps/rank_file/rmaps_rank_file_lex.l
>>> ==============================================================================
>>> --- trunk/orte/mca/rmaps/rank_file/rmaps_rank_file_lex.l    Tue Nov  6 
>>> 16:25:19 2012    (r27573)
>>> +++ trunk/orte/mca/rmaps/rank_file/rmaps_rank_file_lex.l    2012-11-07 
>>> 06:11:05 EST (Wed, 07 Nov 2012)    (r27574)
>>> @@ -36,9 +36,6 @@
>>> 
>>> END_C_DECLS
>>> 
>>> -#define yyterminate() \
>>> -  return orte_rmaps_rank_file_yylex_destroy()
>>> -
>>> /*
>>>  * global variables
>>>  */
>>> _______________________________________________
>>> svn mailing list
>>> s...@open-mpi.org
>>> http://www.open-mpi.org/mailman/listinfo.cgi/svn
>> _______________________________________________
>> devel mailing list
>> de...@open-mpi.org
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

Reply via email to