Apparently I just can't type that freaking word. Thanks Nathan for pointing out the truth ;)
George. On Jul 16, 2013, at 22:56 , Nathan Hjelm <hje...@lanl.gov> wrote: > I think you meant signed. It is signed in both configure.ac and > ompi_datatype_module.c. > > -Nathan > > On Tue, Jul 16, 2013 at 10:48:12PM +0200, George Bosilca wrote: >> It's a typo, MPI_Aint is of course unsigned. >> >> George. >> >> On Jul 16, 2013, at 22:37 , David Goodell (dgoodell) <dgood...@cisco.com> >> wrote: >> >>> On Jul 16, 2013, at 3:22 PM, George Bosilca <bosi...@icl.utk.edu> wrote: >>> >>>> I read your code and it's definitively looking good. I have however few >>>> minor issues with your patch. >>>> >>>> 1. MPI_Aint is unsigned as it must represent the difference between two >>>> memory arbitrary locations. In your MPI_Type_get_[true_]extent_x you go >>>> through size_t possibly reducing it's extent. I would suggest you used >>>> ssize_t instead. >>> >>> MPI_Aint must be signed for Fortran compatibility (among other reasons). >>> If OMPI's MPI_Aint is unsigned then that's a bug in OMPI. >>> >>> -Dave >>> >>> >>> _______________________________________________ >>> devel mailing list >>> de...@open-mpi.org >>> http://www.open-mpi.org/mailman/listinfo.cgi/devel >> >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/devel > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
