The code is well protected against such issues. If one of our base structures
become larger than corresponding predefined structure, the compiler should
trigger an error similar to:
In file included from
../../../ompi/ompi/datatype/ompi_datatype_create_contiguous.c:23:0:
../../../ompi/ompi/datatype/ompi_datatype.h:105:10: error: size of array
'padding' is too large
char padding[PREDEFINED_DATATYPE_PAD - sizeof(ompi_datatype_t)];
^
This is the case for all types that have a predefined enveloppe. Thus, the
commit 30268 was unnecessary as the check was already included in the
compilation by the inclusion of the ompi_debugger_canary.c.
George.
On Jan 13, 2014, at 17:10 , Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote:
> I noticed the following this morning:
>
> * sizeof(ompi_predefined_datatype_t): 512
> * sizeof(ompi_datatype_t): 488
> * padding left: 24
>
> Do we need to increase the size of padding for predefined communicators for
> v1.9?
>
> --
> Jeff Squyres
> jsquy...@cisco.com
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/
>
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
