Fixed and slated for 1.7.5; thanks.

On Jan 23, 2014, at 2:33 AM, Paul Hargrove <phhargr...@lbl.gov> wrote:

> As originally noted in Dec 2011 
> (http://www.open-mpi.org/community/lists/devel/2011/12/10169.php) there is a 
> 1-character typo in generate-asm.pl:
> 
> $ cat -n generate-asm.pl | head -20
>      1  #!/usr/bin/perl -w
>      2  
>      3  
>      4  my $asmarch = shift;
>      5  my $asmformat = shift;
>      6  my $basedir = shift;
>      7  my $output = shift;
>      8  
>      9  if ( ! $asmarch) { 
>     10      print "usage: generate-asm.pl [ASMARCH] [ASMFORMAT] [BASEDIR] 
> [OUTPUT NAME]\n";
>     11      exit(1);
>     12  }
>     13  
>     14  open(INPUT, "$basedir/$asmarch.asm") || 
>     15      die "Could not open $basedir/$asmarch.asm: $!\n";
>     16  open(OUTPUT, ">$output") || die "Could not open $output: $1\n";
>     17  
>     18  $CONFIG = "default";
>     19  $TEXT = "";
>     20  $GLOBAL = "";
> 
> The "$1" on line 16 should actually be "$!".
> The perl variable "$1" is the result of a prior pattern match, of which there 
> ARE NONE.
> The perl variable "$!", however, is the equivalent of "strerror(errno)" in C.
> 
> This typo is still present in today's trunk.
> It is, of course, entirely harmless.
> 
> -Paul
> 
> -- 
> Paul H. Hargrove                          phhargr...@lbl.gov
> Future Technologies Group
> Computer and Data Sciences Department     Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory     Fax: +1-510-486-6900
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Reply via email to