Re: [OMPI devel] [vt] --with-openmpi-inside configure argument

[Bert Wesarg]

On 08/05/2014 02:40 AM, Paul Hargrove wrote:

I noticed that Open MPI is passing
     --with-openmpi-inside=1.7
in the arguments passed to
     ompi/contrib/vt/vt/configure
and
     ompi/contrib/vt/vt/extlib/otf/configure

The extlib/otf case just tests if the value is set, but the top-level
vt/configure is checking for the specific string "1.7":

# Check whether we are inside Open MPI package
inside_openmpi="no"
AC_ARG_WITH(openmpi-inside, [],
[
         AS_IF([test x"$withval" = "xyes" -o x"$withval" = "x1.7"],
         [
                 inside_openmpi="$withval"
                 CPPFLAGS="-DINSIDE_OPENMPI $CPPFLAGS"

                 # Set FC to F77 if Open MPI version < 1.7
                 AS_IF([test x"$withval" = "xyes" -a x"$FC" = x -a x"$F77"
!= x],
                 [FC="$F77"])
         ])
])

That logic looks a bit fragile with respect to any future changes.
Specifically the inner AS_IF is true for the desired condition "version <
1.7" only because the outer AS_IF currently ensures the only possible
values of "$withval" are "yes" and "1.7".

Bert

Noted. But this is not my field. May take some time, because Matthias is still in vacation.

-Paul

--
Dipl.-Inf. Bert Wesarg
wiss. Mitarbeiter

Technische Universität Dresden
Zentrum für Informationsdienste und Hochleistungsrechnen (ZIH)
01062 Dresden
Tel.: +49 (351) 463-42451
Fax: +49 (351) 463-37773
E-Mail: bert.wes...@tu-dresden.de

smime.p7s
Description: S/MIME Cryptographic Signature