Sounds like clearer language - done!
On Aug 4, 2014, at 7:58 PM, Paul Hargrove <phhargr...@lbl.gov> wrote:
> Since "disabled by default" is just part of a macro argument we can say
> anything we want.
> I propose the following:
>
> Index: config/oshmem_configure_options.m4
> ===================================================================
> --- config/oshmem_configure_options.m4 (revision 32424)
> +++ config/oshmem_configure_options.m4 (working copy)
> @@ -22,7 +22,7 @@
> AC_MSG_CHECKING([if want oshmem])
> AC_ARG_ENABLE([oshmem],
> [AC_HELP_STRING([--enable-oshmem],
> - [Enable building the OpenSHMEM interface
> (disabled by default)])],
> + [Enable building the OpenSHMEM interface
> (available on Linux only, where it is enabled by default)])],
> [oshmem_arg_given=yes],
> [oshmem_arg_given=no])
> if test "$oshmem_arg_given" = "yes"; then
>
>
> -Paul
>
>
>
>
> On Mon, Aug 4, 2014 at 7:34 PM, Gilles Gouaillardet
> <gilles.gouaillar...@iferc.org> wrote:
> Paul,
>
> this is a bit trickier ...
>
> on a Linux platform oshmem is built by default,
> on a non Linux platform, oshmem is *not* built by default.
>
> so the configure message (disabled by default) is correct on non Linux
> platform, and incorrect on Linux platform ...
>
> i do not know what should be done, here are some options :
> - have a different behaviour on Linux vs non Linux platforms (by the way,
> does autotools support this ?)
> - disable by default, provide only the --enable-oshmem option (so configure
> abort if --enable-oshmem on non Linux platforms)
> - provide only the --disable-oshmem option, useful only on Linux platforms.
> on non Linux platforms do not build oshmem and this is not an error
> - other ?
>
> Cheers,
>
> Gilles
>
> r31155 | rhc | 2014-03-20 05:32:15 +0900 (Thu, 20 Mar 2014) | 5 lines
>
> As per the thread on ticket #4399, OSHMEM does not support non-Linux
> platforms. So provide a check for Linux and error out if --enable-oshmem is
> given on a non-supported platform. If no OSHMEM option is given (enable or
> disable), then don't attempt to build OSHMEM unless we are on a Linux
> platform. Default to building if we are on Linux for now, pending the outcome
> of the Debian situation.
>
>
> On 2014/08/05 6:41, Paul Hargrove wrote:
>> In both trunk and 1.8.2rc3 the behavior is to enable oshmem by default.
>>
>> In the 1.8.2rc3 tarball the configure help output matches the behavior.
>> HOWEVER, in the trunk the configure help output still says oshmem is
>> DISabled by default.
>>
>> {~/OMPI/ompi-trunk}$ svn info | grep "Revision"
>> Revision: 32422
>> {~/OMPI/ompi-trunk}$ ./configure --help | grep -A1 'enable-oshmem '
>> --enable-oshmem Enable building the OpenSHMEM interface (disabled
>> by
>> default)
>>
>> -Paul
>>
>>
>> On Thu, Jul 24, 2014 at 2:09 PM, Ralph Castain <r...@open-mpi.org> wrote:
>>
>>> Actually, it already is set correctly - the help message was out of date,
>>> so I corrected that.
>>>
>>> On Jul 24, 2014, at 10:58 AM, Marco Atzeri <marco.atz...@gmail.com> wrote:
>>>
>>>> On 24/07/2014 15:52, Ralph Castain wrote:
>>>>> Oshmem should be enabled by default now
>>>> Ok,
>>>> so please reverse the configure switch
>>>>
>>>> --enable-oshmem Enable building the OpenSHMEM interface
>>> (disabled by default)
>>>> I will test enabling it in the meantime.
>>>>
>>>> Regards
>>>> Marco
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> devel mailing list
>>>> de...@open-mpi.org
>>>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>>> Link to this post:
>>> http://www.open-mpi.org/community/lists/devel/2014/07/15254.php
>>>
>>> _______________________________________________
>>> devel mailing list
>>> de...@open-mpi.org
>>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>> Link to this post:
>>> http://www.open-mpi.org/community/lists/devel/2014/07/15261.php
>>>
>>
>>
>> _______________________________________________
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Link to this post:
>> http://www.open-mpi.org/community/lists/devel/2014/08/15502.php
>
>
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/08/15507.php
>
>
>
> --
> Paul H. Hargrove phhargr...@lbl.gov
> Future Technologies Group
> Computer and Data Sciences Department Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/08/15508.php
