I'm not worrying about 1.8.2, but we can take a look at this for 1.8.3 or beyond.
Thanks for working on the trunk! On Aug 10, 2014, at 11:07 PM, Gilles Gouaillardet <gilles.gouaillar...@iferc.org> wrote: > Jeff and all, > > i fixed the trivial errors in the trunk, there are now 11 non trivial > errors. > (commits r32490 to r32497) > > i ran the script vs the v1.8 branch and found 54 errors > (first, you need to > touch Makefile.ompi-rules > in the top-level Open MPI directory in order to make the script happy) > > Cheers, > > Gilles > > On 2014/08/08 22:43, Jeff Squyres (jsquyres) wrote: >> SHORT VERSION >> ============= >> >> The ./contrib/check-help-strings.pl script is showing ***47 coding errors*** >> with regards to using show_help() in components. Here's a summary of the >> offenders: >> >> - ORTE (lumped together because there's a single maintainer :-) ) >> - smcuda and cuda >> - common/verbs >> - bcol >> - mxm >> - openib >> - oshmem >> >> Could the owners of these portions of the code base please run >> ./contrib/check-help-strings.pl and fix the ERRORs that are shown? >> >> Thanks! >> >> MORE DETAIL >> =========== >> >> The first part of ./contrib/check-help-strings.pl's output shows ERRORs -- >> referring to help files that do not exist, or referring to help topics that >> do not exist. >> >> I'm only calling out the ERRORs in this mail -- but the second part of the >> output shows a bazillion WARNINGs, too. These are help topics that are >> probably unused -- they don't seem to be referenced by the code anywhere. >> >> It would be good to clean up all the WARNINGs, too, but the ERRORs are more >> worrisome. >> > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/08/15602.php
