They were equivalent until yesterday.  :-)

I was going to file a PR to bring the changes over to v1.8, but not until they 
had shaken out on master.

Would you mind filing a PR?


On Dec 3, 2014, at 5:56 AM, Artem Polyakov <artpo...@gmail.com> wrote:

> I finally found the clear reason of this strange situation!
> 
> In ompi opal_setup_libltdl.m4 has the following content:
> CPPFLAGS="-I$srcdir -I$srcdir/opal/libltdl"
> AC_EGREP_HEADER([lt_dladvise_init], [opal/libltdl/ltdl.h],
>         [OPAL_HAVE_LTDL_ADVISE=1])
> 
> And in ompi-release opal_setup_libltdl.m4:
> CPPFLAGS="-I$srcdir/opal/libltdl/"
> # Must specifically mention $srcdir here for VPATH builds
> # (this file is in the src tree).
> AC_EGREP_HEADER([lt_dladvise_init], [$srcdir/opal/libltdl/ltdl.h],
>       [OPAL_HAVE_LTDL_ADVISE=1])
> 
> This was thesource of my mistake and confusion. In ompi we check for 
> "opal/libltdl/ltdl.h" and we do need -I$srcdir and in ompi-release we check 
> for "$srcdir/opal/libltdl/ltdl.h". I didn't noticed that wen did the backport 
> from ompi-release to ompi. I really thought that this files are equal.
> 
> I think we need to converge to the unified solution.
> 
> 
> 2014-12-03 10:23 GMT+06:00 Ralph Castain <r...@open-mpi.org>:
> It is working for me, but I’m not sure if that is because of these changes or 
> if it always worked for me. I haven’t tested the slurm integration in awhile.
> 
> 
>> On Dec 2, 2014, at 7:59 PM, Artem Polyakov <artpo...@gmail.com> wrote:
>> 
>> Howard, does current mater fix your problems?
>> 
>> среда, 3 декабря 2014 г. пользователь Artem Polyakov написал:
>> 
>> 2014-12-03 8:30 GMT+06:00 Jeff Squyres (jsquyres) <jsquy...@cisco.com>:
>> On Dec 2, 2014, at 8:43 PM, Artem Polyakov <artpo...@gmail.com> wrote:
>> 
>> > Jeff, your fix brakes my system again. Actually you just reverted my 
>> > changes.
>> 
>> No, I didn't just revert them -- I made changes.  I did forget about the 
>> second -I, though (to be fair, the 2nd -I was the *only* -I in there before 
>> I committed).
>> Yeah! I was speaking figurally :).
>>  
>> Sorry about that -- I've tested your change (without the trailing /) and it 
>> seems to work ok.  I'd go ahead and merge.
>> 
>> --
>> Jeff Squyres
>> jsquy...@cisco.com
>> For corporate legal information go to: 
>> http://www.cisco.com/web/about/doing_business/legal/cri/
>> 
>> _______________________________________________
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Link to this post: 
>> http://www.open-mpi.org/community/lists/devel/2014/12/16414.php
>> 
>> 
>> 
>> -- 
>> С Уважением, Поляков Артем Юрьевич
>> Best regards, Artem Y. Polyakov
>> 
>> 
>> -- 
>> -----
>> Best regards, Artem Polyakov
>> (Mobile mail)
>> _______________________________________________
>> devel mailing list
>> de...@open-mpi.org
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Link to this post: 
>> http://www.open-mpi.org/community/lists/devel/2014/12/16416.php
> 
> 
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: 
> http://www.open-mpi.org/community/lists/devel/2014/12/16417.php
> 
> 
> 
> -- 
> С Уважением, Поляков Артем Юрьевич
> Best regards, Artem Y. Polyakov
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: 
> http://www.open-mpi.org/community/lists/devel/2014/12/16421.php


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Reply via email to