The code is awfully hard to follow - I’m refactoring it on a branch now to try and make it more understandable and will deal with the memory leak there.
> On Dec 24, 2014, at 7:35 AM, Gilles Gouaillardet > <gilles.gouaillar...@gmail.com> wrote: > > Ralph, > > I had second thougts on what i wrote earlier, and i think the code is > correct. e.g. reply cannot be used uninitialized. > > That being said, i think reply should be initialized to null and > OBJ_RELEASE'd if not null on exit in order to avoid a memory leak. > > Sorry for the confusion, > > Gilles > > Ralph Castain <r...@open-mpi.org>さんのメール: >> Hi Nadezhda >> >> I’m afraid this commit is still incorrect as it means that reply can be used >> without ever being initialized. Somehow, you have to OBJ_NEW reply before >> you can use it. >> >> Could you please correct this? >> >> Thanks >> Ralph >> >>> On Dec 24, 2014, at 3:30 AM, git...@crest.iu.edu wrote: >>> >>> This is an automated email from the git hooks/post-receive script. It was >>> generated because a ref change was pushed to the repository containing >>> the project "open-mpi/ompi". >>> >>> The branch, master has been updated >>> via 05af80b3025dbb95bdd4280087450791291d7219 (commit) >>> from b9349d2eb9117c61205c98d5d2d5175d26971d23 (commit) >>> >>> Those revisions listed above that are new to this repository have >>> not appeared on any other notification email; so we list those >>> revisions in full, below. >>> >>> - Log ----------------------------------------------------------------- >>> https://github.com/open-mpi/ompi/commit/05af80b3025dbb95bdd4280087450791291d7219 >>> >>> commit 05af80b3025dbb95bdd4280087450791291d7219 >>> Author: Nadezhda Kogteva <nadezhda.kogt...@itseez.com> >>> Date: Wed Dec 24 13:25:23 2014 +0200 >>> >>> Fix commit bffb2b7a4bb49c9188d942201b8a8f04872ff63c which broke pmix >>> server functionality >>> >>> diff --git a/orte/orted/pmix/pmix_server.c b/orte/orted/pmix/pmix_server.c >>> index 4f0493c..0f4c816 100644 >>> --- a/orte/orted/pmix/pmix_server.c >>> +++ b/orte/orted/pmix/pmix_server.c >>> @@ -1241,9 +1241,9 @@ static void pmix_server_dmdx_resp(int status, >>> orte_process_name_t* sender, >>> /* pass across any returned blobs */ >>> opal_dss.copy_payload(reply, buffer); >>> stored = true; >>> - OBJ_RETAIN(reply); >>> - PMIX_SERVER_QUEUE_SEND(req->peer, req->tag, reply); >>> } >>> + OBJ_RETAIN(reply); >>> + PMIX_SERVER_QUEUE_SEND(req->peer, req->tag, reply); >>> } else { >>> /* If peer has an access to shared memory dstore, check >>> * if we already stored data for the target process. >>> >>> >>> ----------------------------------------------------------------------- >>> >>> Summary of changes: >>> orte/orted/pmix/pmix_server.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> >>> hooks/post-receive >>> -- >>> open-mpi/ompi >>> _______________________________________________ >>> ompi-commits mailing list >>> ompi-comm...@open-mpi.org >>> http://www.open-mpi.org/mailman/listinfo.cgi/ompi-commits >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2014/12/16722.php > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/12/16724.php
