[OMPI devel] Opal atomics question

[Nathan Hjelm]

I am working on cleaning up the atomics in opal and I noticed something
odd. We define opal_atomic_sub_32 and opal_atomic_sub_64 yet only use
opal_atomic_sub_32 once:

./opal/runtime/opal_progress.c:    val = opal_atomic_sub_32(&num_event_users, 
1);

This could easily be changed to:

val = opal_atomic_add_32(&num_event_users, -1);

And then we could remove all both opal_atomic_sub_32 and
opal_atomic_sub_64. Is there a reason to leave these functions in opal?


-Nathan

pgpnPHxehNeMJ.pgp
Description: PGP signature