I see what you are saying. Thank you for pointing it out. Would MTL_OFI_RETRY_UNTIL_DONE be better instead?
Yohann -----Original Message----- From: devel [mailto:devel-boun...@open-mpi.org] On Behalf Of Dave Goodell (dgoodell) Sent: Thursday, September 03, 2015 11:47 AM To: de...@open-mpi.org Subject: Re: [OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-2436-g7adb9b7 On Sep 3, 2015, at 1:03 PM, git...@crest.iu.edu wrote: > diff --git a/ompi/mca/mtl/ofi/mtl_ofi.h b/ompi/mca/mtl/ofi/mtl_ofi.h > index 3584d8a..a035b1c 100644 > --- a/ompi/mca/mtl/ofi/mtl_ofi.h > +++ b/ompi/mca/mtl/ofi/mtl_ofi.h > @@ -38,6 +38,14 @@ > #include "mtl_ofi_endpoint.h" > #include "mtl_ofi_compat.h" > > +#define FI_RETRY_UNTIL_DONE(FUNC) \ > + do { \ > + do { \ > + ret = FUNC; \ > + if(OPAL_LIKELY(0 == ret)) {break;} \ > + } while(-FI_EAGAIN == ret); \ > + } while(0); > + > BEGIN_C_DECLS Minor nit: it would be best to avoid stomping the "FI_" and "fi_" namespaces in OMPI code. I find it unlikely that this particular symbol/macro would ever be defined, but it's usually just a good idea to stay away from the entire namespace. -Dave _______________________________________________ devel mailing list de...@open-mpi.org Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: http://www.open-mpi.org/community/lists/devel/2015/09/17945.php
