Gilles, Thanks again for fixing this !
(we had a patch in the queue but you fixed it faster!) Pavel (Pasha) Shamis --- Computer Science Research Group Computer Science and Math Division Oak Ridge National Laboratory On Sep 11, 2015, at 1:02 AM, Gilles Gouaillardet <gil...@rist.or.jp<mailto:gil...@rist.or.jp>> wrote: Ralph, this is fixed in https://github.com/open-mpi/ompi/commit/a1627feaf74d8562146a1afbfabec60651496c06 Cheers, Gilles On 9/11/2015 1:02 PM, Gilles Gouaillardet wrote: Ralph, will do i think this new warnings are a consequence of the changes i pushed recently (e.g. add the const keyword) Cheers, Gilles On 9/11/2015 12:47 PM, Ralph Castain wrote: FWIW: I’m still seeing these on CentOS7 using gcc 4.8.3 in a debug build: coll_ml_allocation.c:20:13: warning: 'memory_buffer_index' defined but not used [-Wunused-variable] static long memory_buffer_index; ^ coll_ml_module.c: In function 'init_coll_func_pointers': coll_ml_module.c:2529:35: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_allgather = mca_coll_ml_allgather; ^ coll_ml_module.c:2530:36: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_iallgather = mca_coll_ml_allgather_nb; ^ coll_ml_module.c:2537:39: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_allreduce = mca_coll_ml_allreduce_dispatch; ^ coll_ml_module.c:2538:40: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_iallreduce = mca_coll_ml_allreduce_dispatch_nb; ^ coll_ml_module.c:2540:39: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_allreduce = mca_coll_ml_allreduce; ^ coll_ml_module.c:2541:40: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_iallreduce = mca_coll_ml_allreduce_nb; ^ coll_ml_module.c:2578:36: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_reduce = mca_coll_ml_reduce; ^ coll_ml_module.c:2597:33: warning: assignment from incompatible pointer type [enabled by default] coll_base->coll_ireduce = mca_coll_ml_reduce_nb; On Sep 10, 2015, at 7:02 PM, Shamis, Pavel <sham...@ornl.gov<mailto:sham...@ornl.gov>> wrote: Awesome, thanks for fixing this. ________________________________ From: devel <<mailto:devel-boun...@open-mpi.org>devel-boun...@open-mpi.org<mailto:devel-boun...@open-mpi.org>> on behalf of Gilles Gouaillardet <<mailto:gil...@rist.or.jp>gil...@rist.or.jp<mailto:gil...@rist.or.jp>> Sent: Thursday, September 10, 2015 7:39 PM To: Open MPI Developers Subject: Re: [OMPI devel] New master warnings Pasha, i fixed that in <https://github.com/open-mpi/ompi/commit/c404e98dced4104cd3abe7485846368325c3d150> https://github.com/open-mpi/ompi/commit/c404e98dced4104cd3abe7485846368325c3d150 but forgot to post it to the ML ... Cheers, Gilles On 9/11/2015 7:31 AM, Shamis, Pavel wrote: Ralph, I don't see these warnings on my fedora box with gcc 5.1.1. I will try to fix it, but it would be helpful to understand how to reproduce these warnings. Thanks, Pavel (Pasha) Shamis --- Computer Science Research Group Computer Science and Math Division Oak Ridge National Laboratory On Sep 6, 2015, at 7:20 PM, Ralph Castain <<mailto:r...@open-mpi.org>r...@open-mpi.org<mailto:r...@open-mpi.org>> wrote: Just saw these this afternoon: coll_ml_hier_algorithms.c: In function 'ml_coll_schedule_setup': coll_ml_hier_algorithms.c:180:13: warning: passing argument 13 of 'opal_free_list_init' from incompatible pointer type [enabled by default] ); ^ In file included from ../../../../ompi/request/request.h:35:0, from ../../../../ompi/mca/coll/coll.h:72, from ../../../../ompi/mca/coll/ml/coll_ml.h:27, from coll_ml_hier_algorithms.c:15: ../../../../opal/class/opal_free_list.h:127:19: note: expected 'opal_free_list_item_init_fn_t' but argument is of type 'void (*)(struct opal_free_list_item_t *, void *)' OPAL_DECLSPEC int opal_free_list_init (opal_free_list_t *free_list, ^ coll_ml_module.c: In function 'init_lists': coll_ml_module.c:2622:31: warning: passing argument 13 of 'opal_free_list_init' from incompatible pointer type [enabled by default] init_ml_message_desc, ml_module); ^ In file included from ../../../../ompi/communicator/comm_request.h:16:0, from ../../../../ompi/communicator/communicator.h:35, from coll_ml_module.c:32: ../../../../opal/class/opal_free_list.h:127:19: note: expected 'opal_free_list_item_init_fn_t' but argument is of type 'void (*)(struct opal_free_list_item_t *, void *)' OPAL_DECLSPEC int opal_free_list_init (opal_free_list_t *free_list, ^ coll_ml_module.c:2640:32: warning: passing argument 13 of 'opal_free_list_init' from incompatible pointer type [enabled by default] init_ml_fragment_desc, ml_module); ^ In file included from ../../../../ompi/communicator/comm_request.h:16:0, from ../../../../ompi/communicator/communicator.h:35, from coll_ml_module.c:32: ../../../../opal/class/opal_free_list.h:127:19: note: expected 'opal_free_list_item_init_fn_t' but argument is of type 'void (*)(struct opal_free_list_item_t *, void *)' OPAL_DECLSPEC int opal_free_list_init (opal_free_list_t *free_list, _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: <http://www.open-mpi.org/mailman/listinfo.cgi/devel> http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: <http://www.open-mpi.org/community/lists/devel/2015/09/17977.php> http://www.open-mpi.org/community/lists/devel/2015/09/17977.php _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: http://www.open-mpi.org/community/lists/devel/2015/09/17998.php _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: <http://www.open-mpi.org/mailman/listinfo.cgi/devel> http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: <http://www.open-mpi.org/community/lists/devel/2015/09/18000.php> http://www.open-mpi.org/community/lists/devel/2015/09/18000.php _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: http://www.open-mpi.org/community/lists/devel/2015/09/18001.php _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: http://www.open-mpi.org/community/lists/devel/2015/09/18002.php _______________________________________________ devel mailing list de...@open-mpi.org<mailto:de...@open-mpi.org> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel Link to this post: http://www.open-mpi.org/community/lists/devel/2015/09/18003.php
