FWIW: I don’t think that’s the issue here. I don’t see these warnings on my CentOS7 box, for example. I think this is driven by the fact that odin has some very old compilers and a very different environment, and so it has historically generated more warnings.
The warnings often are valid - they just don’t get issued by other compilers, or configure activates other code paths. > On Nov 11, 2015, at 6:17 AM, Dave Goodell (dgoodell) <dgood...@cisco.com> > wrote: > > Once you squash all these warnings, you could set up a little bit of Jenkins > or Travis CI logic to check for PRs that add new warnings and marks them > appropriately. Of course, with people making commits directly to master, > warnings introduced by those direct commits will be ascribed to those who > make PRs against master. But at least you'd catch them quickly. > > The MPICH project has a script that could easily be adapted to extract only > the warnings: http://git.mpich.org/mpich.git/blob/HEAD:/maint/clmake.in > > Alternatively/additionally you could have a build bot that watches for new > commits to master, runs a quick build on each new commit, and sends mail to > de...@open-mpi.org and the offender with the new warnings that have been > introduced. > > -Dave > >> On Nov 10, 2015, at 10:51 PM, Ralph Castain <r...@open-mpi.org> wrote: >> >> This is from an older compiler, so take it for what it’s worth - I’ll take >> care of the orte ones, but the bcol, nbc, and osc ones will need addressing: >> >> pmix1_server_south.c: In function 'myerr': >> pmix1_server_south.c:58: warning: 'nm' may be used uninitialized in this >> function >> >> pmix1_client.c: In function 'myerr': >> pmix1_client.c:44: warning: 'nm' may be used uninitialized in this function >> >> base/rml_base_channel_handlers.c: In function >> 'orte_rml_base_close_channel_send_callback': >> base/rml_base_channel_handlers.c:95: warning: unused variable ‘peer' >> >> runtime/orte_data_server.c: In function 'orte_data_server': >> runtime/orte_data_server.c:174: warning: 'uid' may be used uninitialized in >> this function >> >> util/dash_host/dash_host.c: In function 'orte_util_add_dash_host_nodes': >> util/dash_host/dash_host.c:57: warning: 'slots' may be used uninitialized in >> this function >> util/dash_host/dash_host.c:58: warning: 'slots_given' may be used >> uninitialized in this function >> >> qos_ack_component.c: In function 'orte_qos_ack_recv_msg_timeout_callback': >> qos_ack_component.c:534: warning: unused variable 'msg' >> qos_ack_component.c: In function 'orte_qos_ack_msg_send_callback': >> qos_ack_component.c:667: warning: unused variable 'channel' >> qos_ack_component.c: In function 'ack_recv': >> qos_ack_component.c:316: warning: 'room_num' may be used uninitialized in >> this function >> >> ras_slurm_module.c: In function 'recv_data': >> ras_slurm_module.c:778: warning: 'app' may be used uninitialized in this >> function >> >> bcol_ptpcoll_allreduce.c: In function >> 'bcol_ptpcoll_allreduce_narraying_init': >> bcol_ptpcoll_allreduce.c:236: warning: unused variable 'dtype' >> bcol_ptpcoll_allreduce.c:235: warning: unused variable ‘count' >> >> nbc.c: In function 'NBC_Progress': >> nbc.c:297: warning: 'size' may be used uninitialized in this function >> >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_accumulate_w_req': >> osc_pt2pt_comm.c:424: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:420: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_put_w_req': >> osc_pt2pt_comm.c:250: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:242: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_callback': >> osc_pt2pt_data_move.c:1615: warning: unused variable 'incoming_length' >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_accumulate_internal': >> osc_pt2pt_comm.c:951: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:947: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_control_send': >> osc_pt2pt_data_move.c:213: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c:212: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_gacc_long_start': >> osc_pt2pt_data_move.c:961: warning: 'acc_data' may be used uninitialized in >> this function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_gacc_start': >> osc_pt2pt_data_move.c:914: warning: 'acc_data' may be used uninitialized in >> this function >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_rget_internal': >> osc_pt2pt_comm.c:744: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:740: warning: 'frag' may be used uninitialized in this >> function >> osc_pt2pt_data_move.c: In function 'ompi_osc_pt2pt_acc_long_start': >> osc_pt2pt_data_move.c:831: warning: 'acc_data' may be used uninitialized in >> this function >> osc_pt2pt_comm.c: In function 'ompi_osc_pt2pt_compare_and_swap': >> osc_pt2pt_comm.c:601: warning: 'ptr' may be used uninitialized in this >> function >> osc_pt2pt_comm.c:594: warning: 'frag' may be used uninitialized in this >> function >> >> osc_rdma_active_target.c: In function 'ompi_osc_rdma_post_atomic': >> osc_rdma_active_target.c:183: warning: 'frag' may be used uninitialized in >> this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_compare_and_swap': >> osc_rdma_accumulate.c:693: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:691: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_passive_target.c: In function 'ompi_osc_rdma_unlock_atomic': >> osc_rdma_passive_target.c:239: warning: 'peer' may be used uninitialized in >> this function >> osc_rdma_passive_target.c: In function 'ompi_osc_rdma_lock_atomic': >> osc_rdma_lock.h:116: warning: 'frag' may be used uninitialized in this >> function >> osc_rdma_lock.h:116: warning: 'frag' may be used uninitialized in this >> function >> osc_rdma_passive_target.c: In function 'ompi_osc_rdma_lock_all_atomic': >> osc_rdma_lock.h:116: warning: 'frag' may be used uninitialized in this >> function >> osc_rdma_comm.c: In function 'ompi_osc_rdma_put': >> osc_rdma_comm.c:705: warning: 'target_address' may be used uninitialized in >> this function >> osc_rdma_comm.c:704: warning: 'target_handle' may be used uninitialized in >> this function >> osc_rdma_comm.c: In function 'ompi_osc_rdma_rget': >> osc_rdma_comm.c:740: warning: 'source_address' may be used uninitialized in >> this function >> osc_rdma_comm.c:739: warning: 'source_handle' may be used uninitialized in >> this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_get_accumulate': >> osc_rdma_accumulate.c:743: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:742: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_accumulate': >> osc_rdma_accumulate.c:743: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:742: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_raccumulate': >> osc_rdma_accumulate.c:743: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:742: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_comm.c: In function 'ompi_osc_rdma_rput': >> osc_rdma_comm.c:705: warning: 'target_address' may be used uninitialized in >> this function >> osc_rdma_comm.c:704: warning: 'target_handle' may be used uninitialized in >> this function >> osc_rdma_comm.c: In function 'ompi_osc_rdma_get': >> osc_rdma_comm.c:740: warning: 'source_address' may be used uninitialized in >> this function >> osc_rdma_comm.c:739: warning: 'source_handle' may be used uninitialized in >> this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_fetch_and_op': >> osc_rdma_accumulate.c:743: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:742: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_accumulate.c: In function 'ompi_osc_rdma_rget_accumulate': >> osc_rdma_accumulate.c:743: warning: 'target_address' may be used >> uninitialized in this function >> osc_rdma_accumulate.c:742: warning: 'target_handle' may be used >> uninitialized in this function >> osc_rdma_dynamic.c: In function 'ompi_osc_rdma_find_dynamic_region': >> osc_rdma_lock.h:116: warning: 'frag' may be used uninitialized in this >> function >> >> monitoring_test.c:81: warning: ‘flush_cvar_idx’ defined but not used >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2015/11/18357.php > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2015/11/18358.php
