i did forget that indeed ... and i just pushed it
Cheers,
Gilles
On 1/7/2016 12:33 AM, Ralph Castain wrote:
Hmmm…I don’t see a second commit message anywhere. Did you perhaps
forget to push it?
Thanks for the explanation!
Ralph
On Jan 6, 2016, at 2:30 AM, Gilles Gouaillardet
<gilles.gouaillar...@gmail.com
<mailto:gilles.gouaillar...@gmail.com>> wrote:
Hi Ralph,
That solves the multiple mtt failures that occurred with inter
communicators and mpi_procs_cutoff.
You can reproduce this with allgather_inter from ibm/collective,
--mca mpi_procs_cutoff 0, 8 tasks and two nodes.
Basically, a proc_list[i] can be a sentinel, so it is not always
correct to simply dereference proc_list[i] in order to access its
proc_name.
Note this commit is incomplete and I pushed a second one right after
I figured it out.
Cheers,
Gilles
On Wednesday, January 6, 2016, Ralph Castain <r...@open-mpi.org
<mailto:r...@open-mpi.org>> wrote:
Hi Gilles
Could you please explain this one - I honestly don’t understand
the change, and haven’t encountered a problem.
Thanks
Ralph
> On Jan 5, 2016, at 11:22 PM, git...@crest.iu.edu <javascript:;>
wrote:
>
> This is an automated email from the git hooks/post-receive
script. It was
> generated because a ref change was pushed to the repository
containing
> the project "open-mpi/ompi".
>
> The branch, master has been updated
> via 213b2abde47cf02ba3152a301d3ec0ffeec54438 (commit)
> from e4bdad09c1bf7f11dada5ae6ac32e052b553ce4b (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.
>
> - Log
-----------------------------------------------------------------
>
https://github.com/open-mpi/ompi/commit/213b2abde47cf02ba3152a301d3ec0ffeec54438
>
> commit 213b2abde47cf02ba3152a301d3ec0ffeec54438
> Author: Gilles Gouaillardet <gil...@rist.or.jp <javascript:;>>
> Date: Wed Jan 6 16:21:13 2016 +0900
>
> dpm: correctly handle procs_cutoff in ompi_dpm_connect_accept()
>
> diff --git a/ompi/dpm/dpm.c b/ompi/dpm/dpm.c
> index 9a236d0..b1c562e 100644
> --- a/ompi/dpm/dpm.c
> +++ b/ompi/dpm/dpm.c
> @@ -16,7 +16,7 @@
> * Copyright (c) 2011-2015 Los Alamos National Security, LLC.
All rights
> * reserved.
> * Copyright (c) 2013-2015 Intel, Inc. All rights reserved
> - * Copyright (c) 2014-2015 Research Organization for
Information Science
> + * Copyright (c) 2014-2016 Research Organization for
Information Science
> * and Technology (RIST). All rights
reserved.
> * $COPYRIGHT$
> *
> @@ -167,7 +167,13 @@ int
ompi_dpm_connect_accept(ompi_communicator_t *comm, int root,
> dense = false;
> }
> for (i=0; i < size; i++) {
> - rc = opal_convert_process_name_to_string(&nstring,
&(proc_list[i]->super.proc_name));
> + opal_process_name_t proc_name;
> + if (ompi_proc_is_sentinel (proc_list[i])) {
> + proc_name = ompi_proc_sentinel_to_name
((intptr_t) proc_list[i]);
> + } else {
> + proc_name = proc_list[i]->super.proc_name;
> + }
> + rc = opal_convert_process_name_to_string(&nstring,
&proc_name);
> if (OPAL_SUCCESS != rc) {
> if (!dense) {
> free(proc_list);
>
>
>
-----------------------------------------------------------------------
>
> Summary of changes:
> ompi/dpm/dpm.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>
> hooks/post-receive
> --
> open-mpi/ompi
> _______________________________________________
> ompi-commits mailing list
> ompi-comm...@open-mpi.org <javascript:;>
> http://www.open-mpi.org/mailman/listinfo.cgi/ompi-commits
_______________________________________________
devel mailing list
de...@open-mpi.org <javascript:;>
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Link to this post:
http://www.open-mpi.org/community/lists/devel/2016/01/18473.php
_______________________________________________
devel mailing list
de...@open-mpi.org <mailto:de...@open-mpi.org>
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Link to this post:
http://www.open-mpi.org/community/lists/devel/2016/01/18474.php
_______________________________________________
devel mailing list
de...@open-mpi.org
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Link to this post:
http://www.open-mpi.org/community/lists/devel/2016/01/18475.php
