I noticed that opal/mca/memory/patcher/memory_patcher_component.c includes
<sys/syscall.h> without ever checking (not even in the .m4 fragment) that
this header exists.

At the moment, AIX is the only O/S I've encountered that doesn't have a
sys/syscall.h.
However, I think the possibility of others needs to be considered.
My recommendation is that the .m4 disqualify the component if sys/syscall.h
does not exist.

I was actually surprised that on AIX memory:patcher was compiled despite
all of the "no" results in the following:

--- MCA component memory:patcher (m4 configuration macro, priority 41)
checking for MCA component memory:patcher compile mode... static
checking for __curbrk symbol... no
checking whether __mmap prototype exists... yes
checking whether __mmap symbol exists... no
checking whether __syscall prototype exists... no
checking whether __syscall symbol exists... no
checking linux/mman.h usability... no
checking linux/mman.h presence... no
checking for linux/mman.h... no
checking if MCA component memory:patcher can compile... yes


-Paul


-- 
Paul H. Hargrove                          phhargr...@lbl.gov
Computer Languages & Systems Software (CLaSS) Group
Computer Science Department               Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory     Fax: +1-510-486-6900

Reply via email to