On Mon, May 30, 2011 at 3:51 AM, Vivek Natarajan <vivek.nat...@gmail.com> wrote:
> On Wed, May 4, 2011 at 10:54 PM, Javier Cardona <jav...@cozybit.com> wrote:
>> Mesh beacons no longer use all-zeroes BSSID.  Beacon frames for MBSS,
>> infrastructure BSS, or IBSS are differentiated by the Capability
>> Information field in the Beacon frame.  A mesh STA sets the ESS and IBSS
>> subfields to 0 in transmitted Beacon or Probe Response management
>> frames.
>
> This breaks P2P mode as a P2P STA also sets the ESS and IBSS subfields
> to zero. Is there any other way to find if it is a mesh other than
> this check?

Bummer.  I guess that's a collision between WiFi Alliance and IEEE,
respectively the organizations standardizing P2P and 802.11s.
The 11s draft is pretty clear about that.  I can consult the task
group and see if they have thought about this conflict.

>> index fbf6f33..62e542a 100644
>> --- a/net/wireless/scan.c
>> +++ b/net/wireless/scan.c
>
>> @@ -407,7 +407,7 @@ cfg80211_bss_update(struct cfg80211_registered_device 
>> *dev,
>>
>>        res->ts = jiffies;
>>
>> -       if (is_zero_ether_addr(res->pub.bssid)) {
>> +       if (WLAN_CAPABILITY_IS_MBSS(res->pub.capability)) {
>>                /* must be mesh, verify */
>
> Reverting the above change, makes P2P work. Any other better fix?

We could check that the WLAN_CAPABILITY_IS_MBSS *and* that the bssid
matches the TA.  Do you think that would work?

Thanks,

Javier



-- 
Javier Cardona
cozybit Inc.
http://www.cozybit.com
_______________________________________________
Devel mailing list
Devel@lists.open80211s.org
http://open80211s.com/mailman/listinfo/devel

Reply via email to