> + } else if (is_broadcast_ether_addr(target_addr) &&
> + (target_flags & MP_F_DO)) {
please indent to below is_
> + mpath = mesh_path_lookup(orig_addr, sdata);
> + if (mpath) {
> + if (flags & PREQ_F_PREP)
> + reply = true;
> + if (root_is_gate)
> + mesh_path_add_gate(mpath);
> + }
> } else {
> rcu_read_lock();
> mpath = mesh_path_lookup(target_addr, sdata);
> @@ -581,11 +594,20 @@ static void hwmp_preq_frame_process(struct
> ieee80211_sub_if_data *sdata,
> ttl = ifmsh->mshcfg.element_ttl;
> if (ttl != 0) {
> mhwmp_dbg("replying to the PREQ");
> - mesh_path_sel_frame_tx(MPATH_PREP, 0, orig_addr,
> - cpu_to_le32(orig_sn), 0, target_addr,
> - cpu_to_le32(target_sn), mgmt->sa, 0, ttl,
> - cpu_to_le32(lifetime), cpu_to_le32(metric),
> - 0, sdata);
> + if (!is_broadcast_ether_addr(target_addr))
> + mesh_path_sel_frame_tx(MPATH_PREP, 0, orig_addr,
> + cpu_to_le32(orig_sn), 0, target_addr,
> + cpu_to_le32(target_sn), mgmt->sa, 0, ttl,
> + cpu_to_le32(lifetime), cpu_to_le32(metric),
> + 0, sdata);
> + else {
please put braces around all pieces of an if/else if on one branch
Maybe you should run checkpatch :-)
johannes
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel