On Fri, 2012-06-08 at 13:31 -0700, Jason Abele wrote:

> +     if (sta->tx_packets > 100)
> +             rate = max(ewma_read(&sta->avg_rate), 10UL);
> +     else
> +             /* Not enough traffic sent, use rx signal strengh as proxy */
> +             rate = rssi_get_rate(sta);

This just seems completely wrong to me. There's very little correlation
between bitrates and RSSI, in fact, we once had 0 dBm power by accident
and got better performance than with 15 dBm power (due to another bug,
but still)...

Looking at the code that uses this, I also note:

>       /* This should be adjusted for each device */
>         int device_constant = 1 << ARITH_SHIFT;

which seems *totally* wrong. Maybe it's time to rethink this code?

johannes

_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel

Reply via email to