On Tue, 2012-06-12 at 15:50 +0800, Chun-Yeow Yeoh wrote:
> /**
> + * enum - mesh PREQ element flags
Please fix this -- it has to be
enum ieee80211_preq_flags - ...
I was going to fix it up for you, but there are a lot of instances here.
> +/**
> + * enum - mesh PREQ element per target flags
> + *
> + * @TO_FLAG: target only subfield
> + * @USN_FLAG: unknown target HWMP sequence number subfield
> + */
> +enum ieee80211_preq_target_flags {
> + TO_FLAG = 1<<0,
> + USN_FLAG = 1<<2,
Since this is a fairly generic header, maybe they should have some
prefixes, at least IEEE80211_ or maybe IEEE80211_PREQ_?
> +/**
> + * enum - root mesh STA mode identifier used by dot11MeshHWMPRootMode
> + *
> + * @IEEE80211_NO_ROOT: the mesh STA is not a root mesh STA (default)
> + * @IEEE80211_ROOT: the mesh STA is a root mesh STA if greater than this
> value
> + * @IEEE80211_PROACTIVE_PREQ_NO_PREP: the mesh STA is a root mesh STA
> supports
> + * the proactive PREQ with proactive PREP subfield set to 0
> + * @IEEE80211_PROACTIVE_PREQ_WITH_PREP: the mesh STA is a root mesh STA
> + * supports the proactive PREQ with proactive PREP subfield set to 1
> + * @IEEE80211_PROACTIVE_RANN: the mesh STA is a root mesh STA supports
> + * the proactive RANN
> + */
> +enum {
That enum probably needs a name for kernel-doc to work
> + IEEE80211_NO_ROOT = 0,
These should have more specific prefixes I think?
johannes
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
