On Fri, Aug 17, 2012 at 11:05:15PM +0800, Yeoh Chun-Yeow wrote: > * @IEEE80211_KEY_FLAG_SW_MGMT: This flag should be set by the driver for a > * CCMP key if it requires CCMP encryption of management frames (MFP) to > * be done in software. > > With this flag, it should do software encryption in CCMP, so removing > it should be ensure ath5k doing hardware encryption for MFP, am I > right?
Right -- but afaik ath5k won't support MFP in hardware anyway. Without that flag it should _not_ work -- I was just pointing out that nohwcrypt=1 would skip a test case in case you want to be sure that IEEE80211_HW_MFP_CAPABLE works in both configurations, i.e.: should work (unless there are ath5k bugs): IEEE80211_HW_MFP_CAPABLE + nohwcrypt=1 IEEE80211_HW_MFP_CAPABLE + nohwcrypt=0 + IEEE80211_KEY_FLAG_SW_MGMT should not work: missing IEEE80211_HW_MFP_CAPABLE IEEE80211_HW_MFP_CAPABLE + nohwcrypt=0 (without IEEE80211_KEY_FLAG_SW_MGMT) So the test would just show that you have MFP turned on and are using hardware encryption -- it would break, and then work again when you add IEEE80211_KEY_FLAG_SW_MGMT back in. Sorry for the confusion. -- Bob Copeland %% www.bobcopeland.com _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
