On Fri, Feb 1, 2013 at 9:54 AM, Bob Copeland <[email protected]> wrote: > On Thu, Jan 31, 2013 at 08:56:24PM -0800, Thomas Pedersen wrote: >> + /* NOTE: the mesh ID IE won't be in order */ > > I think it should be fixed from a QOI standpoint.
I'll see what I can do, but on first pass it looked much more painful to do this the right way. > So, how about merge_ies()? :) Hopefully that's out of scope right now :). We can't modify the scan IEs since they're allocated in nl80211 and cfg80211_scan_request->ie pointer is const. >> + pos = skb_put(skb, 2 + ssid_len); >> + *pos++ = WLAN_EID_MESH_ID; >> + *pos++ = ssid_len; >> + if (ssid_len) >> + memcpy(pos, ssid, ssid_len); > > You could just do one call to skb_put with all the bytes you need, > and memcpy() works with ssid_len == 0. I suspected this could've been nicer. Thanks. -- Thomas _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
