Thomas, On Thu, Mar 14, 2013 at 7:44 PM, Thomas Pedersen <[email protected]> wrote: > Thanks for testing. No this behavior is not expected. > > Mesh needs drivers to honor certain (pass-through) filters: > FIF_OTHER_BSS, and FIF_ALLMULTI. Looking at how ath9k handles this I > found the tidbit: > > if (sc->nvifs > 1 || (sc->rx.rxfilter & FIF_OTHER_BSS)) { > /* This is needed for older chips */ > if (sc->sc_ah->hw_version.macVersion <= AR_SREV_VERSION_9160) > rfilt |= ATH9K_RX_FILTER_PROM; > > Which apparently puts the card into promiscuous mode as a hack. Did > you happen to test with the ar9220 card as well?
Ah, good finding. Yes, I remember I introduce that as a workaround for cards that would not correctly implement the FIF_OTHER_BSS filter. Relevant commit logs below: commit 5eb6ba83aa326e2f2cf9109d20df5d6a497b36bb Author: Javier Cardona <[email protected]> Date: Thu Aug 20 19:12:07 2009 -0700 ath9k: Add support FIF_OTHER_BSS filtering mode. Support for FIF_OTHER_BSS was missing. This patch adds support for this filtering mode which in turn resolves a problem where mesh interfaces would not receive broadcast traffic. Signed-off-by: Javier Cardona <[email protected]> Signed-off-by: John W. Linville <[email protected]> commit a549459c96ba99a691aa1cafeabdd327a7a2bfcf Author: Thomas Wagner <[email protected]> Date: Tue Sep 25 21:32:55 2012 +0530 ath9k: Fix rx filtering issue for older chips We need to have the promiscuous mode enabled for older chipsets so that the olderchips hardware does not filters out some valid/necessary frames that need to be sent to mac80211. Fix this by enabling promiscus mode for all the chipsets whose macversion <= AR9160 chipsets. This should fix https://bugzilla.kernel.org/show_bug.cgi?id=45591 shafi: made the fix generic by having the frame filtering disabled for chipsets older than AR9280. Cc: Javier Cardona <[email protected]> Signed-off-by: Thomas Wagner <[email protected]> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]> Signed-off-by: John W. Linville <[email protected]> Cheers, Javier -- Javier Cardona cozybit Inc. http://www.cozybit.com _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
