Thanks, Chaoxing Lin. Javier
On Wednesday, April 10, 2013, Chaoxing Lin wrote: > With these 3 fixes, peer deletion is good. > > > -----Original Message----- > From: [email protected] <javascript:;> [mailto: > [email protected] <javascript:;>] On Behalf Of Javier > Cardona > Sent: Tuesday, April 09, 2013 5:54 PM > To: [email protected] <javascript:;> > Subject: Re: authsae bug in handle_del_peer() > > Hi Chaoxing, > > Thanks for reporting. I've applied all three fixes. Please let us know > if peer deletion now works for you. > > Best, > > Javier > > On Tue, Apr 9, 2013 at 11:43 AM, Chaoxing Lin > <[email protected]<javascript:;>> > wrote: > > Another bug in the same function: > > > > One character difference kills the meshd-nl80211 > > > > static int handle_del_peer(struct netlink_config_s *nlcfg, > > struct nl_msg *msg, void *arg) { ... > > > > if ((peer = find_peer(nla_data(tb[NL80211_ATTR_MAX]), 0))) > //SHOULD BE NL80211_ATTR_MAC > > delete_peer(&peer); > > ... > > return 0; > > } > > > > -----Original Message----- > > From: [email protected] <javascript:;> > > [mailto:[email protected] <javascript:;>] On Behalf Of > Chaoxing Lin > > Sent: Tuesday, April 09, 2013 1:51 PM > > To: [email protected] <javascript:;> > > Subject: RE: authsae bug in handle_del_peer() > > > > After remove ";" in line 357, more problem in this function > handle_del_peer() It can't compile well. > > > > The "struct candidate **peer;" should be changed to "struct candidate > *peer;" > > And all references to peer in this function should be changed > accordingly. > > > > > > -----Original Message----- > > From: [email protected] <javascript:;> > > [mailto:[email protected] <javascript:;>] On Behalf Of > Chaoxing Lin > > Sent: Tuesday, April 09, 2013 1:43 PM > > To: [email protected] <javascript:;> > > Subject: authsae bug in handle_del_peer() > > > > > > File: linux/meshd-nl80211.c > > Line 357~358: > > > > 357 if (nla_get_u32(tb[NL80211_ATTR_IFINDEX]) != nlcfg->ifindex); > > 358 return -1; > > > > The ";" at the end of line 357 is the problem. > > > > The impact is severe. > > handle_del_peer() always return -1 prematurelly. > > > > Meshd-nl80211 can not handle station delete event from kernel. > > > > > > _______________________________________________ > > Devel mailing list > > [email protected] <javascript:;> > > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel > > _______________________________________________ > > Devel mailing list > > [email protected] <javascript:;> > > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel > > _______________________________________________ > > Devel mailing list > > [email protected] <javascript:;> > > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel > > > > -- > Javier Cardona > cozybit Inc. > http://www.cozybit.com > _______________________________________________ > Devel mailing list > [email protected] <javascript:;> > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel > _______________________________________________ > Devel mailing list > [email protected] <javascript:;> > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel > -- Javier Cardona cozybit Inc. http://www.cozybit.com
_______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
