Sorry for leaving this open for so long. I think it didn't hurt since
the merge window was open anyway.
> + * @basic_rates: per-band bitmap of basic rates to use when creating the mesh
Does per-band really make sense? The mesh channel is also determined at
join time.
> static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
> {
> struct cfg80211_registered_device *rdev = info->user_ptr[0];
> @@ -7460,6 +7487,22 @@ static int nl80211_join_mesh(struct sk_buff *skb,
> struct genl_info *info)
> nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE])))
> return -EINVAL;
>
> + if (info->attrs[NL80211_ATTR_BSS_BASIC_RATES]) {
I think you should consider allowing this attribute only if the channel
is also specified (NL80211_ATTR_WIPHY_FREQ, parsed below), and not make
it nested with rates for both bands but just the selected band.
johannes
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
