Re: [PATCH 5/5] mac80211: process mesh channel switching using beacon

[Johannes Berg]

On Fri, 2013-09-13 at 16:36 -0700, Chun-Yeow Yeoh wrote:

>       err = ieee80211_parse_ch_switch_ie(sdata, elems, beacon,
>                                          ifibss->chandef.chan->band,
>                                          sta_flags, ifibss->bssid,
> -                                        &params.count, &mode,
> +                                        &params.count, &mode, &ttl,
>                                          &params.chandef);

I think it'd be worth doing some refactoring here to have an output
struct ... the parameters to this function are getting unreal. :)

> +     if (!cfg80211_chandef_usable(sdata->local->hw.wiphy, &params.chandef,
> +                                  IEEE80211_CHAN_DISABLED)) {
> +             sdata_info(sdata,
> +                        "mesh STA %pM switches to unsupported channel (%d 
> MHz, width:%d, CF1/2: %d/%d MHz), aborting\n",
> +                        sdata->vif.addr,
> +                        params.chandef.chan->center_freq,
> +                        params.chandef.width,
> +                        params.chandef.center_freq1,
> +                        params.chandef.center_freq2);
> +     }

Seems like you should *do* something here, like return false?

johannes

_______________________________________________
Devel mailing list
Devel@lists.open80211s.org
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel