On Wed, 2013-10-02 at 01:02 -0700, Chun-Yeow Yeoh wrote:
> Finalizing the required procedures for channel switching completion based
> on the procedures  defined in the IEEE Std 802.11-2012 section 10.9.8.4.3:
>  * Add the function for updating the beacon and probe response frames
>    with CSA and MCSP elements during the period of switching to the new
>    channel.
>  * The ifmsh->csa_settings is set to NULL and the CSA and MCSP elements
>    will then be removed from the beacon or probe response frames once the
>    new channel is switched to.
> 
> Signed-off-by: Chun-Yeow Yeoh <[email protected]>
> ---
> v2: fix typo mistake, commit message and return value.  
>     use spinlock to protect csa_settings  (Johannes Berg)

Is the spinlock really the best idea? It seems you could just use RCU
instead and avoid the extra lock? It's not exactly a hotpath, but the
paths that are assigning this should be locked already (I'd hope,
otherwise there might be more races) and the reader could be RCU.

johannes

_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel

Reply via email to