On Thu, Jul 10, 2014 at 11:44:32AM -0700, Jason Mobarak wrote: > Hi Bob, Thanks for cleaning this bit up. How does this code compare > to the equivalent bits in authsae? What was stopping us from porting > authsae's implementation of the state machine to wpa_supp?
There's still a fair amount missing from this compared to authsae. But I think it's mostly things like frame retransmission timers and such. Ultimately it would probably make sense to separate out the event processing (auth_handle_sae) from the state machine aspects (which I don't think are in the tree anywhere). Authsae's license contains some provisions that may make it difficult/impossible to incorporate code from it directly (it is BSD-like but IIRC has a no-GPL proviso so I can't say that it is fully compatible with hostapd's). > What do you think would constitute a good review of this code? > Someone (Javier Cardona or Dan Harkins) reviewing the code? I wonder > if there's anyone on the hostapd project that would be able to > adequately review it... I'm pretty sure Jouni can do an adequate review, but review from any interested party would be welcome. The standard is pretty clear on all the bits that need to happen. I'll try to post v4 tonight. -- Bob Copeland %% www.bobcopeland.com _______________________________________________ Devel mailing list Devel@lists.open80211s.org http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
