> The subject doesn't really match what this does.  I would also describe
> the new kernel behavior in the commit log in addition to the motivation.
> 
> Maybe something like this:

Thank you for your comment. I will change the subject and the commit log.

> From a cursory glance I think this needs to be GFP_ATOMIC -- don't you get
> lockdep warnings?  (If not, make sure CONFIG_PROVE_LOCKING is enabled, and
> that you aren't hitting other lockdep warnings prior to this code running.)
> This code is in an RCU read critical section as far as I can tell.

Yes, this should be GFP_ATOMIC. I will change.

_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel

Reply via email to