On Fri, 2009-04-17 at 14:37 +1000, Brad Hards wrote:
> The IDL for WriteStream request looks like:
> typedef [flag(NDR_NOALIGN)] struct {
> [subcontext(2), flag(NDR_REMAINING)] DATA_BLOB data;
> } WriteStream_req;
>
> Could we just use a SBinary_short instead? [MS-OXCROPS Section 2.2.8.3
> RopWriteStream]Moving from the existing data blob to a SBinary_short implies we avoid the existing NDR layer checks and move them back to the MAPI stack. In case we have a call pack error, samba's dcerpc stack returns a dcerpc_fault_ndr error. If we change this to a data structure matching more closely MS specs, we'll have to handle this situation on our own and deal with MAPI_E_CALL_FAILED properly. This also means we have to introduce more boundary checks and do additional processing. I'm not sure how much benefits we would get compared to the issues it may introduce. Discussion opened anyway ;-) Cheers, Julien. -- Julien Kerihuel [email protected] OpenChange Project Manager GPG Fingerprint: 0B55 783D A781 6329 108A B609 7EF6 FE11 A35F 1F79
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
