On Fri, 2009-12-18 at 16:53 +0530, Johnny Jacob wrote: > Hello, > > Attached a patch for MonitorNotification (IMAPISupport) to make it > non-blocking. The API takes a callback to check if it should continue > processing notifications or return. > > **Patch causes a API change**
Hi Johnny, The new version of this patch sounds good for integration. Maybe one last remark (since you also mentioned it within your patch). It may be useful to refactor the 3rd argument within a data structure which would take a pointer on a timeval structure and a pointer on the notification callback. The main idea being to make the 2sec notification timeout customizable and the whole idea a bit more generic. -- Julien Kerihuel [email protected] OpenChange Project Manager GPG Fingerprint: 0B55 783D A781 6329 108A B609 7EF6 FE11 A35F 1F79
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
