Hello. On Mon, 2010-11-08 at 23:04, Tormod Volden wrote: > On Mon, Nov 8, 2010 at 12:21 PM, Stefan Schmidt wrote: > >> In one case below it replaces a hardcoded 5 ms wait. If a device > >> is broken and needs more time than it says, we should add quirks > >> for the specific device. > > > > I agree with the concept, but we would need such a quirk system in place > > before > > we change the default. The main problem is here that our main target the > > Openmoko devices are broken in this regard. It does not report the time in > > bwPollTimeout correctly. > > > > So I'm not going to apply this patch until such a quirk system exists. > > I was browsing through the archive now and I see that this has been > brought up before. Do your OpenMokos return 0, or some insane value?
Insane value. :( I had check for 0 to "detect" our broken bootloader but this quick fix failed. > The DFU standard generously allows up to 4.7 hours :) The values I had were pretty random sadly. > I would like to make something a bit more nicer than a uncommented, > magic 5000, also before we have a full quirk system in place. Anything you have in mind here? Without a fixed number we could only trigger on some high numbers we do not really expect from the device and rank it as broken timeout value and fall back to a fixed timeout. Not sure if such a heuristic will work out for many devices though. > BTW, thanks for testing it on an OpenMoko, which I can not do. I > understand dfu-util was originally made for it, so I respect that we > do not want to break it. I really want to see dfu-util support more devices but keeping it in a working state for the openmoko devices while going forward is a must have for me. :) Maybe I should look myself for some cheap usb dongles that support DFU. Some cheap BT USB dongles or such should be ok. Just need to find out which are supporting a firmware upgrade and which do only have ROM based firmware. regards Stefan Schmidt _______________________________________________ devel mailing list devel@lists.openmoko.org https://lists.openmoko.org/mailman/listinfo/devel
