On Friday 08 February 2008, Henning Westerholt wrote: > On Friday 08 February 2008, Henning Westerholt wrote: > > Revision: 3668 > > http://openser.svn.sourceforge.net/openser/?rev=3668&view=rev > > Author: henningw > > Date: 2008-02-08 06:32:23 -0800 (Fri, 08 Feb 2008) > > > > Log Message: > > ----------- > > - port db_text and db_berkeley to the new core DB API > > - remove free_* methods that are not needed anymore > > - adjust structure to the other SQL based modules > > - basic queries works, but otherwise not that much tested > > Hi Will, > > i've a question about the db_berkeley module in regards to the value > handling: > > In the bdb_convert_row function, around line 218 you free all memory != > STRING or STR. This is correct according to my understanding of the logic. > This memory is freed in the db_free_row function if the result is not used > any more. > > In the bdb_append_row function, around line 363 you free all memory != > STRING, STR is thus freed in this function too. Is this correct? I think if > you do this, then there will be invalid STR values in the result set. Can > you please review if this code is valid? > > I would also really appreciate if you could do some tests after my changes, > perhaps you've some kind test suite for this module. I don't have a > extensive test environment for this module available, unfortunally. > > Thank you,
Hi Will, any updates on this? Cheers, Henning _______________________________________________ Devel mailing list [email protected] http://lists.openser.org/cgi-bin/mailman/listinfo/devel
