I see.... For 2) - maybe instead of having each module/function keeping a copy, the SDP should be cloned into transaction.....This will be more efficient and elegant
For 3) - as we do no have no user for SDP parser for the moment, I will make the fix to be sure that the SDP hook is set to zero after cloning the message into shm Regards, Bogdan Ovidiu Sas wrote: > Hello Bogdan, > > see inline: > > On Thu, Mar 6, 2008 at 4:31 AM, Bogdan-Andrei Iancu > <[EMAIL PROTECTED]> wrote: > >> Hi Ovidiu, >> >> I was looking over this new parser and I have couple of questions: >> >> 1) is it right now used in anyplace in openser? >> > No, right now, the parser is not used anywhere in the openser code. > > >> 2) there are some cloning function ? what is the purpose for? >> > The entire parsing is done just like for the other SIP headers, inside > the PKG_MEM. > The cloning functions are provided for modules that will want to keep > a copy of the parsed SDP in SHM_MEM. > The purpose of this cloning methods is to provide the ability to match > the SDP offer with an SDP answer inside the same transaction or > dialog. > > >> 3) I guess there is no stateful support right now - the sdp parsed >> structure is not copies in transaction (shm_mem) and the pointer is >> neither reset -> some bogus reference from shm_mem to a pkg_mem. >> > You are correct, there is no stateful support right now. It will be > the job of a module to provide stateful support by using the cloning > functions. > > > >> Regards, >> Bogdan >> >> >> >> Ovidiu Sas wrote: >> > Revision: 3860 >> > http://openser.svn.sourceforge.net/openser/?rev=3860&view=rev >> > Author: osas >> > Date: 2008-03-05 12:26:36 -0800 (Wed, 05 Mar 2008) >> > >> > Log Message: >> > ----------- >> > openser new feature: sdp parser >> > >> > Modified Paths: >> > -------------- >> > trunk/Makefile.sources >> > trunk/parser/msg_parser.c >> > trunk/parser/msg_parser.h >> > >> > Added Paths: >> > ----------- >> > trunk/parser/sdp/ >> > trunk/parser/sdp/sdp.c >> > trunk/parser/sdp/sdp.h >> > trunk/parser/sdp/sdp_helpr_funcs.c >> > trunk/parser/sdp/sdp_helpr_funcs.h >> > >> > >> > This was sent by the SourceForge.net collaborative development platform, >> the world's largest Open Source development site. >> > >> > _______________________________________________ >> > Devel mailing list >> > [email protected] >> > http://lists.openser.org/cgi-bin/mailman/listinfo/devel >> > >> > >> >> >> > > _______________________________________________ Devel mailing list [email protected] http://lists.openser.org/cgi-bin/mailman/listinfo/devel
