Bugs item #1597607, was opened at 2006-11-16 12:18 Message generated for change (Comment added) made by bogdan_iancu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1597607&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver devel Status: Open Resolution: None Priority: 2 Private: No Submitted By: axlh (axlh) >Assigned to: Juha Heinanen (juhe) Summary: ENUM related functions should accept ENUM number without '+' Initial Comment: The ENUM functions in OpenSER fail with an e.164 number without '+', while I think it should accept them. (I can't find any mention of a required '+' in any e.164 document I could find) I know it is possible to prefix '+' manually to the r-uri for enum_query(), but for enum_fquery() this is impossible as the From is immutable in OpenSER. (uac_replace_from() doesn't do the trick) ---------------------------------------------------------------------- >Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2008-04-04 19:19 Message: Logged In: YES user_id=1275325 Originator: NO Juha, thanks for taking this over :) ---------------------------------------------------------------------- Comment By: Henning Westerholt (henningw) Date: 2008-03-07 18:57 Message: Logged In: YES user_id=337916 Originator: NO Hi, its now possible to use more then two parameters.. Anyway, is this still a valid bug, or can this now achieved by some other means? This report is really low priorized, and getting really stale.. Cheers, Henning ---------------------------------------------------------------------- Comment By: Klaus Darilion (klaus_darilion) Date: 2007-12-17 11:23 Message: Logged In: YES user_id=1318360 Originator: NO Is it possible to extend the core to handle more the 2 parameters? A workaround would be to specify the AVP as module parameter. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2007-12-14 19:24 Message: Logged In: NO i started to work on bogdan's enum_avp proposal, but since a function can only take two params, enum_avp cannot be written without sacrificing something. since i don't know the application behind this feature request, i don't know if it is ok to leave suffix or service out. -- juha ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2006-11-27 20:31 Message: Logged In: YES user_id=1275325 Originator: NO after more discussion with Klaus and Juha, the idea was to keep the "+" sign as required by the enum functions (e.164 cheking) and to increas the flexibility with a new function called enum_avp() - this will take the URI from an AVP, so whatever source and previous manipulation will be possible. bogdan ---------------------------------------------------------------------- Comment By: Bogdan-Andrei Iancu (bogdan_iancu) Date: 2006-11-27 12:01 Message: Logged In: YES user_id=1275325 Originator: NO Hi there, yes, it looks like there is an issue with the "+" sign. I asked Juha and Klaus (the Enum guys) if "+" is mandatory for E.164 numbers and here is Klaus response: <quote> Some cites: 4.2 numbering plan ... A numbering plan does not include prefixes, suffixes, and additional information required to complete a call. 4.6 international prefix A digit or combination of digits used to indicate that the number following is an International Public Telecommunication Number. Some observations: The "international public telecommunication number" does not include a prefix (section 6.2) 11 International prefix It is recommended by the ITU-T that the Administrations of countries that have not yet introduced automatic inter- national operation, or Administrations and international network operators that are, for various reasons, defining or revising their numbering plans, adopt an international prefix (a code for access to the international automatic network) composed of the two digits 00 . In accordance with Recommendation E.123, the symbol "+" is recommended to indicate that an international prefix is required. To my understand this means that the E.164 phone number does not include the plus sign, but the plus sign indicates that the following number is an E.164 phone number. RFC 3761: 2.1. Application Unique String The Application Unique String is a fully qualified E.164 number minus any non-digit characters except for the '+' character which appears at the beginning of the number. The "+" is kept to provide a well understood anchor for the AUS in order to distinguish it from other telephone numbers that are not part of the E.164 namespace. For example, the E.164 number could start out as "+44-116-496-1234". To ensure that no syntactic sugar is allowed into the AUS, all non- digits except for "+" are removed, yielding "+441164961234". RFC 3761 uses the + sign. AFAIK this is used to distinguish from non E.164 ENUM applications, which does not use the + sign in the Application Unique String and in the matching pattern of the regular expression. </quote> so, in my oppinion, there are 2 thinks to be done: 1) to make sure all enum functions works with or without "+" 2) togive some possibility to apply changes on the FROM URI before being used by the enum_fquery() functions. regards, bogdan ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1597607&group_id=139143 _______________________________________________ Devel mailing list Devel@lists.openser.org http://lists.openser.org/cgi-bin/mailman/listinfo/devel
