Patches item #1933630, was opened at 2008-04-03 14:23
Message generated for change (Comment added) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1933630&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: dialog callbacks: mi enhancements

Initial Comment:
For modules sitting on top of the dialog module it is not possible to retrieve 
the call specific context out of a callback, because the pointer to the context 
is stored inside the dialog callback structure.

It would make sense to enhance the existing dialog callbacks with a new one 
that will be used by the mi commands to list the call specific context of the 
data that is hold by the module that is sitting on top of the dialog module.

An example is the sst module.  The call specific context is:
typedef struct sst_info_st {
        enum sst_flags requester;
        enum sst_flags supported;
        unsigned int interval;
} sst_info_t;


It would make sense to create a new mi command for the dialog module (like 
dlg_enhanced_list) that will print in addition to the dialog context, the 
context of each module that registered an mi callback with the dialog module.

Thoughts?


Regards,
Ovidiu Sas

----------------------------------------------------------------------

>Comment By: Ovidiu Sas (osas)
Date: 2008-04-15 10:45

Message:
Logged In: YES 
user_id=1395524
Originator: YES

If there are no objections, I will push the patch into the gate this
week.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:34

Message:
Logged In: YES 
user_id=1395524
Originator: YES

re-targeting "Feature Request" -> "Patches"

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:33

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: sst.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:32

Message:
Logged In: YES 
user_id=1395524
Originator: YES

File Added: dialog.patch

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-11 19:31

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Here are some proposed patches for adding this new feature:
 - mi.patch
   - provides enhancements to the mi API (build an mi node out of the tree
structure)
 - dialog.patch
   - new callback: DLGCB_MI_CTX_QUERY (callback for mi query commands)
 - sst.patch
   - first module to use the DLGCB_MI_CTX_QUERY


Here's the result:
dialog::  hash=898:913256572
        state:: 2
        timestart:: 0
        timeout:: 0
        callid:: [EMAIL PROTECTED]
        from_uri:: sip:[EMAIL PROTECTED]:5050
        from_tag:: 1
        caller_contact:: sip:[EMAIL PROTECTED]:5050
        caller_cseq:: 1
        caller_route_set:: 
        caller_bind_addr:: udp:10.11.10.63:5060
        to_uri:: sip:[EMAIL PROTECTED]:5060
        to_tag:: 
        callee_contact:: 
        callee_cseq:: 
        callee_route_set:: 
        callee_bind_addr:: 
        sst::  requester_flags=4 supported_flags=0 interval=2400



Regards,
Ovidiu Sas
File Added: mi.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1933630&group_id=139143

_______________________________________________
Devel mailing list
Devel@lists.openser.org
http://lists.openser.org/cgi-bin/mailman/listinfo/devel

Reply via email to